fix(VSelect): closing chip removes selection (#19242)

fixes #19235 Co-authored-by: John Leider <john@vuetifyjs.com>
vuetifyjs · Feb 21, 2024 · b5c7660 · b5c7660
1 parent 22aff0a
commit b5c7660
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/packages/vuetify/src/components/VAutocomplete/VAutocomplete.tsx b/packages/vuetify/src/components/VAutocomplete/VAutocomplete.tsx
@@ -322,13 +322,14 @@ export const VAutocomplete = genericComponent<new <
 
     const isSelecting = shallowRef(false)
 
-    function select (item: ListItem, add = true) {
+    function select (item: ListItem) {
       if (item.props.disabled) return
 
-      if (props.multiple) {
-        const index = model.value.findIndex(selection => props.valueComparator(selection.value, item.value))
+      const index = model.value.findIndex(selection => props.valueComparator(selection.value, item.value))
+      const add = index === -1
 
-        if (index === -1) {
+      if (props.multiple) {
+        if (add) {
           model.value = [...model.value, item]
         } else {
           const value = [...model.value]
@@ -544,7 +545,7 @@ export const VAutocomplete = genericComponent<new <
                     e.stopPropagation()
                     e.preventDefault()
 
-                    select(item, false)
+                    select(item)
                   }
 
                   const slotProps = {

diff --git a/packages/vuetify/src/components/VSelect/VSelect.tsx b/packages/vuetify/src/components/VSelect/VSelect.tsx
@@ -253,18 +253,19 @@ export const VSelect = genericComponent<new <
       }
     }
     function select (item: ListItem) {
-      if (props.multiple) {
-        const index = model.value.findIndex(selection => props.valueComparator(selection.value, item.value))
+      const index = model.value.findIndex(selection => props.valueComparator(selection.value, item.value))
+      const add = index === -1
 
-        if (index === -1) {
+      if (props.multiple) {
+        if (add) {
           model.value = [...model.value, item]
         } else {
           const value = [...model.value]
           value.splice(index, 1)
           model.value = value
         }
       } else {
-        model.value = [item]
+        model.value = add ? [item] : []
         menu.value = false
       }
     }