fix(activatable): stop activator event listener propagation

fixes #3333
vuetifyjs · Jan 19, 2020 · be58395 · be58395
1 parent 86133ea
commit be58395
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/packages/vuetify/src/mixins/activatable/__tests__/activatable.spec.ts b/packages/vuetify/src/mixins/activatable/__tests__/activatable.spec.ts
@@ -175,4 +175,16 @@ describe('activatable.ts', () => {
 
     document.body.removeChild(el)
   })
+
+  it('should stop event propagation when activator is clicked', () => {
+    const wrapper = mountFunction()
+
+    const stopPropagation = jest.fn()
+    const onClick = { stopPropagation }
+    const listeners = wrapper.vm.genActivatorListeners()
+
+    listeners.click(onClick as any)
+
+    expect(stopPropagation).toHaveBeenCalled()
+  })
 })
diff --git a/packages/vuetify/src/mixins/activatable/index.ts b/packages/vuetify/src/mixins/activatable/index.ts
@@ -109,6 +109,8 @@ export default baseMixins.extend({
           const activator = this.getActivator(e)
           if (activator) activator.focus()
 
+          e.stopPropagation()
+
           this.isActive = !this.isActive
         }
       }