chore: fix prop types error

vuetifyjs · May 18, 2023 · c759e8c · c759e8c
1 parent 8e2dc26
commit c759e8c
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 13 deletions.
diff --git a/packages/vuetify/src/components/VRangeSlider/VRangeSlider.tsx b/packages/vuetify/src/components/VRangeSlider/VRangeSlider.tsx
@@ -169,17 +169,17 @@ export const VRangeSlider = genericComponent<VSliderSlots>()({
                 <input
                   id={ `${id.value}_start` }
                   name={ props.name || id.value }
-                  disabled={ props.disabled }
-                  readonly={ props.readonly }
+                  disabled={ !!props.disabled }
+                  readonly={ !!props.readonly }
                   tabindex="-1"
                   value={ model.value[0] }
                 />
 
                 <input
                   id={ `${id.value}_stop` }
                   name={ props.name || id.value }
-                  disabled={ props.disabled }
-                  readonly={ props.readonly }
+                  disabled={ !!props.disabled }
+                  readonly={ !!props.readonly }
                   tabindex="-1"
                   value={ model.value[1] }
                 />

diff --git a/packages/vuetify/src/components/VSlider/VSlider.tsx b/packages/vuetify/src/components/VSlider/VSlider.tsx
@@ -142,8 +142,8 @@ export const VSlider = genericComponent<VSliderSlots>()({
                 <input
                   id={ id.value }
                   name={ props.name || id.value }
-                  disabled={ props.disabled }
-                  readonly={ props.readonly }
+                  disabled={ !!props.disabled }
+                  readonly={ !!props.readonly }
                   tabindex="-1"
                   value={ model.value }
                 />

diff --git a/packages/vuetify/src/components/VSlider/VSliderThumb.tsx b/packages/vuetify/src/components/VSlider/VSliderThumb.tsx
@@ -146,7 +146,7 @@ export const VSliderThumb = genericComponent<VSliderThumbSlots>()({
           aria-valuemin={ props.min }
           aria-valuemax={ props.max }
           aria-valuenow={ props.modelValue }
-          aria-readonly={ readonly.value }
+          aria-readonly={ !!readonly.value }
           aria-orientation={ direction.value }
           onKeydown={ !readonly.value ? onKeydown : undefined }
         >

diff --git a/packages/vuetify/src/components/VSlider/slider.ts b/packages/vuetify/src/components/VSlider/slider.ts
@@ -23,7 +23,7 @@ type SliderProvide = {
   color: Ref<string | undefined>
   decimals: Ref<number>
   direction: Ref<'vertical' | 'horizontal'>
-  disabled: Ref<boolean | undefined>
+  disabled: Ref<boolean | null | undefined>
   elevation: Ref<number | string | undefined>
   min: Ref<number>
   max: Ref<number>
@@ -33,7 +33,7 @@ type SliderProvide = {
   onSliderTouchstart: (e: TouchEvent) => void
   parseMouseMove: (e: MouseEvent | TouchEvent) => number
   position: (val: number) => number
-  readonly: Ref<boolean | undefined>
+  readonly: Ref<boolean | null | undefined>
   rounded: Ref<boolean | number | string | undefined>
   roundValue: (value: number) => number
   thumbLabel: Ref<boolean | string | undefined>
@@ -73,9 +73,15 @@ function getPosition (e: MouseEvent | TouchEvent, position: 'clientX' | 'clientY
 }
 
 export const makeSliderProps = propsFactory({
-  disabled: Boolean,
+  disabled: {
+    type: Boolean as PropType<boolean | null>,
+    default: null,
+  },
   error: Boolean,
-  readonly: Boolean,
+  readonly: {
+    type: Boolean as PropType<boolean | null>,
+    default: null,
+  },
   max: {
     type: [Number, String],
     default: 100,

diff --git a/packages/vuetify/src/composables/validation.ts b/packages/vuetify/src/composables/validation.ts
@@ -39,7 +39,7 @@ export interface ValidationProps {
 
 export const makeValidationProps = propsFactory({
   disabled: {
-    type: Boolean,
+    type: Boolean as PropType<boolean | null>,
     default: null,
   },
   error: Boolean,
@@ -54,7 +54,7 @@ export const makeValidationProps = propsFactory({
   name: String,
   label: String,
   readonly: {
-    type: Boolean,
+    type: Boolean as PropType<boolean | null>,
     default: null,
   },
   rules: {