fix(VDataTable): skip default sort if custom function returns null

vuetifyjs · Apr 15, 2024 · d368340 · d368340
1 parent 6205614
commit d368340
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/vuetify/src/components/VDataTable/composables/sort.ts b/packages/vuetify/src/components/VDataTable/composables/sort.ts
@@ -143,15 +143,15 @@ export function sortItems<T extends Record<string, any>> (
       if (customRawSorters?.[sortKey]) {
         const customResult = customRawSorters[sortKey](sortARaw, sortBRaw)
 
-        if (!customResult) continue
+        if (customResult == null) continue
 
         return customResult
       }
 
       if (customSorters?.[sortKey]) {
         const customResult = customSorters[sortKey](sortA, sortB)
 
-        if (!customResult) continue
+        if (customResult == null) continue
 
         return customResult
       }

diff --git a/packages/vuetify/src/components/VDataTable/types.ts b/packages/vuetify/src/components/VDataTable/types.ts
@@ -5,7 +5,7 @@ import type { provideSelection, SelectableItem } from './composables/select'
 import type { FilterFunction, InternalItem } from '@/composables/filter'
 import type { SelectItemKey } from '@/util'
 
-export type DataTableCompareFunction<T = any> = (a: T, b: T) => number
+export type DataTableCompareFunction<T = any> = (a: T, b: T) => number | null
 
 export type DataTableHeader<T = Record<string, any>> = {
   key?: 'data-table-group' | 'data-table-select' | 'data-table-expand' | (string & {})