Skip to content

Commit

Permalink
fix(VTable): font-color, size, and icon size
Browse files Browse the repository at this point in the history
  • Loading branch information
johnleider committed Nov 16, 2023
1 parent 6901d24 commit ecbf74e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 6 additions & 1 deletion packages/vuetify/src/components/VTable/VTable.sass
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,25 @@
.v-table
@include tools.theme($table-theme...)

font-size: $table-font-size
transition-duration: $table-transition-duration
transition-property: $table-transition-property
transition-timing-function: $table-transition-timing-function

.v-table-divider
border-right: $table-border

.v-icon
font-size: $table-icon-size
height: $table-icon-size
width: $table-icon-size

.v-table__wrapper
> table
> thead
> tr
> th
border-bottom: $table-border
color: rgba(var(--v-theme-on-surface), var(--v-medium-emphasis-opacity))

> tbody
> tr
Expand Down
2 changes: 2 additions & 0 deletions packages/vuetify/src/components/VTable/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ $table-density: ('default': 0, 'comfortable': -2, 'compact': -4) !default;
$table-header-height: 56px !default;
$table-header-font-weight: 500 !default;
$table-header-font-size: tools.map-deep-get(settings.$typography, 'caption', 'size') !default;
$table-font-size: tools.map-deep-get(settings.$typography, 'body-2', 'size') !default;
$table-icon-size: 1.5rem !default;
$table-row-height: var(--v-table-row-height, 52px) !default;
$table-row-font-size: tools.map-deep-get(settings.$typography, 'subtitle-2', 'size') !default;
$table-border-color: rgba(var(--v-border-color), var(--v-border-opacity)) !default;
Expand Down

3 comments on commit ecbf74e

@dreysolano
Copy link

@dreysolano dreysolano commented on ecbf74e Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnleider The .v-icon font size change overrides the actual size specified on the <v-icon> component, effectively forcing the $table-icon-size regardless of what is provided to v-icon.

I'm confused as to why such a change would have been made.

@johnleider
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was reverted 02adf35

@dreysolano
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnleider. I see this was just deployed πŸŽ‰

Please sign in to comment.