Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting id="some_element_id" on a v-layout component just adds id to the list of classes #1079

Closed
roblav96 opened this issue Jul 21, 2017 · 5 comments
Assignees
Labels
T: bug Functionality that does not work as intended/expected

Comments

@roblav96
Copy link

roblav96 commented Jul 21, 2017

Steps to reproduce

Create an element like so:

<v-layout column id="sbar_table_container" class="flex-1 scroll-y"></v-layout>

Versions

├── vue@2.4.1
├── vuetify@0.14.5

What is expected ?

<div id="sbar_table_container" class="layout column flex-1 scroll-y"></div>

What is actually happening ?

<div class="layout column flex-1 scroll-y id"></div>

The component is removing the id attribute all together and adding id to the class list.

Reproduction Link

Please provide a template to a reproduction link, sorry I'm not familiar with making a jsfiddle from scratch 😞

johnleider added a commit that referenced this issue Jul 21, 2017
@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Jul 21, 2017
@johnleider johnleider self-assigned this Jul 21, 2017
@capttrousers
Copy link

This is also affect v-flex, not sure if the fix addresses that too. Here's a codepen demonstrating it:

https://codepen.io/anon/pen/vJYLLX

@johnleider
Copy link
Member

The fix was applied to all grid components, container, layout, flex and spacer.

@nocrates
Copy link

@johnleider Would this fix also address "data-id" or other data attributes? I have seen the same problem, where the "data-id" attribute ends up rendered as part of the class instead of a separate attribute.

@adi-zz
Copy link

adi-zz commented Mar 26, 2018

@nocrates - no (see #3673)

@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

5 participants