fix(VSparkline): fix duplicate id on VSparkline path #11262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR removes the
id
property on the SVGpath
element from VSparkline.Motivation and Context
VSparkline has a duplicated
id
. It uses the sameid
for it'spath
element and thelinearGradient
.This creates an issue during SSR rehydration where the path disappear as it can't find the gradient.
How Has This Been Tested?
This has been tested visually to check it's still renders properly. The snapshots have also been updated.
I haven't been able to link my local Vuetify to a Nuxt project to check removing the duplicated
id
does fix the issue, however it seems very likely it will.Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).