Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSparkline): fix duplicate id on VSparkline path #11262

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

adrienbaron
Copy link
Contributor

Description

This MR removes the id property on the SVG path element from VSparkline.

Motivation and Context

VSparkline has a duplicated id. It uses the same id for it's path element and the linearGradient.
This creates an issue during SSR rehydration where the path disappear as it can't find the gradient.

How Has This Been Tested?

This has been tested visually to check it's still renders properly. The snapshots have also been updated.
I haven't been able to link my local Vuetify to a Nuxt project to check removing the duplicated id does fix the issue, however it seems very likely it will.

Markup:

<template>
  <v-container>
    <v-sparkline
      auto-draw
      :value="[0, 2, 5, 9, 5, 10, 3, 5, 0, 0, 1, 8, 2, 9, 0]"
      :gradient="['#623195', '#9e6dd1']"
      :line-width="2"
    />
  </v-container>
</template>

<script>
  export default {
    data: () => ({
    //
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@adrienbaron adrienbaron changed the title fix(vsparkline): fix duplicate id on VSparkline path fix(VSparkline): fix duplicate id on VSparkline path Apr 28, 2020
@johnleider johnleider added C: VSparkline VSparkline T: bug Functionality that does not work as intended/expected labels Apr 30, 2020
@johnleider johnleider added this to the v2.2.x milestone Apr 30, 2020
@johnleider johnleider merged commit 4a785ff into vuetifyjs:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VSparkline VSparkline T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants