Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTextField): remove erroneous white space for outlined style #11748

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

piktur
Copy link
Contributor

@piktur piktur commented Jun 29, 2020

Description

Removes erroneous whitespace in VTextField legend

Motivation and Context

Chrome auto-translate replaces whitespace with non-whitespace characters ie. when translated to French (France) this character becomes "La"

How Has This Been Tested?

Visually

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider self-requested a review July 7, 2020 16:27
@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Jul 7, 2020
@johnleider
Copy link
Member

Please provide a Playground that depicts the issue.

@johnleider johnleider added the S: needs reproduction The issue does not contain a valid reproduction label Jul 7, 2020
@johnleider johnleider added this to the v2.3.x milestone Jul 7, 2020
@piktur
Copy link
Contributor Author

piktur commented Jul 8, 2020

@johnleider Thanks for your reponse.

In order to replicate the issue:

Then you will see
Screen Shot 2020-07-08 at 12 16 57 pm

Screen Shot 2020-07-08 at 12 22 54 pm

@KaelWD KaelWD force-pushed the master branch 4 times, most recently from 902f181 to a45560a Compare July 23, 2020 14:39
@johnleider johnleider removed the S: needs reproduction The issue does not contain a valid reproduction label Sep 29, 2020
@johnleider johnleider merged commit d723457 into vuetifyjs:master Sep 29, 2020
@johnleider johnleider changed the title fix(VTextField): remove erroneous white space #11747 fix(VTextField): remove erroneous white space for outlined style Sep 29, 2020
@johnleider
Copy link
Member

Didn't catch this the related issue.

fixes #11747

@johnleider johnleider added the C: VTextField VTextField label Sep 29, 2020
johnleider added a commit that referenced this pull request Sep 30, 2020
jyburns pushed a commit to jyburns/vuetify that referenced this pull request Oct 11, 2020
jyburns pushed a commit to jyburns/vuetify that referenced this pull request Oct 11, 2020
francois2metz pushed a commit to francois2metz/vuetify that referenced this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTextField VTextField T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Erroneous space inserted within VTextField <legend> is translated by Chrome auto-translate
2 participants