Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Calendar event ending midnight not visible #11767

Closed
TheOnlyError opened this issue Jun 30, 2020 · 4 comments · Fixed by #13667
Closed

[Bug Report] Calendar event ending midnight not visible #11767

TheOnlyError opened this issue Jun 30, 2020 · 4 comments · Fixed by #13667
Assignees
@KaelWD
Labels
C: VCalendar VCalendar T: bug Functionality that does not work as intended/expected
Milestone
v2.5.x

Comments

@TheOnlyError
Copy link

TheOnlyError commented Jun 30, 2020 •
edited

Environment

Vuetify Version: 2.3.2
Last working version: 2.2.34
Vue Version: 2.6.11
Browsers: Chrome 83.0.4103.116
OS: Windows 10

Steps to reproduce

See codepen for 2.2.34 where it still worked: https://codepen.io/theonlyerror/pen/mdVqrzz?editable=true&editors=111%3Dhttps%3A%2F%2Fvuetifyjs.com%2Fen%2Fcomponents%2Fcalendars%2F

  1. Scroll down to see event from 09 to 00.

Expected Behavior

The event should show like it used to.

Actual Behavior

The event no longer shows.

Reproduction Link

https://codepen.io/theonlyerror/pen/rNxYMQW?editable=true&editors=111%3Dhttps%3A%2F%2Fvuetifyjs.com%2Fen%2Fcomponents%2Fcalendars%2F
@ghost ghost added the S: triage label Jun 30, 2020
@Jaykob86
Copy link

It is reproducable also on documentation page, in drag and drop demo.

@dbettini
Copy link

dbettini commented Sep 14, 2020 •
edited

Something that might be connected - events that start and end at the same time have a minimal height, i.e. they always appear on the calendar. However, events that start and end at midnight of the same day do not appear at all.
At this point you'd think it's the same bug as OP, but it isn't, since this was also broken in version 2.2.34, where OP bug could not be reproduced.

@dbettini dbettini mentioned this issue Sep 14, 2020
Closed
@fdebiesse
Copy link

Hello, any news about this issue ? @TheOnlyError did you find a workaround maybe ?

@DaanSterk
Copy link

Hello, any news about this issue ? @TheOnlyError did you find a workaround maybe ?

My workaround: if an event ends at midnight, change its end time to 23:59 and override the template to display "00:00".

whg added a commit to whg/vuetify that referenced this issue May 17, 2021
@whg
fix(VCalendar): display events ending at midnight
ca2b672 
fixes #m.spec.ts
 PASS   Vuetify  src/components/VSnackbar/__tests__/VSnackbar.spec.ts
 PASS   Vuetify  src/components/VInput/__tests__/VInput.spec.ts
 PASS   Vuetify  src/mixins/validatable/__tests__/validatable.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/VEditDialog.spec.ts
 PASS   Vuetify  src/components/VDialog/__tests__/VDialog.spec.ts
 PASS   Vuetify  src/components/VOverflowBtn/__tests__/VOverflowBtn.spec.ts
 PASS   Vuetify  src/components/VForm/__tests__/VForm.spec.ts
 PASS   Vuetify  src/components/VBanner/__tests__/VBanner.spec.ts
 PASS   Vuetify  src/components/VGrid/__tests__/VCol.spec.ts
 PASS   Vuetify  src/components/VStepper/__tests__/VStepperStep.spec.ts
 PASS   Vuetify  src/components/VAlert/__tests__/VAlert.spec.ts
 PASS   Vuetify  src/components/VItemGroup/__tests__/VItemGroup.spec.ts
 PASS   Vuetify  src/components/VList/__tests__/VListItem.spec.ts
 PASS   Vuetify  src/components/VData/__tests__/VData.spec.ts
 PASS   Vuetify  src/components/VIcon/__tests__/VIcon.spec.ts
 PASS   Vuetify  src/components/VBadge/__tests__/VBadge.spec.ts
 PASS   Vuetify  src/components/VProgressLinear/__tests__/VProgressLinear.spec.ts
 PASS   Vuetify  src/directives/ripple/__tests__/ripple.spec.ts
 PASS   Vuetify  src/mixins/overlayable/__tests__/overlayable.spec.ts
 PASS   Vuetify  src/util/__tests__/colorUtils.spec.ts
 PASS   Vuetify  src/components/VTimePicker/__tests__/VTimePickerTitle.spec.ts
 PASS   Vuetify  src/components/VChip/__tests__/VChip.spec.ts
 PASS   Vuetify  src/components/VTreeview/__tests__/VTreeviewNode.spec.ts
 PASS   Vuetify  src/mixins/activatable/__tests__/activatable.spec.ts
 PASS   Vuetify  src/components/VColorPicker/__tests__/VColorPickerPreview.spec.ts
 PASS   Vuetify  src/components/VProgressCircular/__tests__/VProgressCircular.spec.ts
 PASS   Vuetify  src/components/VExpansionPanel/__tests__/VExpansionPanelHeader.spec.ts
 PASS   Vuetify  src/directives/click-outside/__tests__/click-outside-shadow-dom.spec.ts
 PASS   Vuetify  src/components/VColorPicker/util/__tests__/index.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/VSimpleTable.spec.ts
 PASS   Vuetify  src/components/VStepper/__tests__/VStepper.spec.ts
 PASS   Vuetify  src/components/VDatePicker/__tests__/VDatePickerTitle.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/Row.spec.ts
 PASS   Vuetify  src/components/VChipGroup/__tests__/VChipGroup.spec.ts
 PASS   Vuetify  src/components/VCalendar/mixins/__tests__/calendar-base.spec.ts
 PASS   Vuetify  src/components/VVirtualScroll/__tests__/VVirtualScroll.spec.ts
 PASS   Vuetify  src/components/VCard/__tests__/VCard.spec.ts
 PASS   Vuetify  src/components/VAppBar/__tests__/VAppBarNavIcon.spec.ts
 PASS   Vuetify  src/directives/touch/__tests__/touch.spec.ts
 PASS   Vuetify  src/directives/click-outside/__tests__/click-outside.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/MobileRow.spec.ts
 PASS   Vuetify  src/util/__tests__/mergeData.spec.ts
 PASS   Vuetify  src/components/VTimeline/__tests__/VTimelineItem.spec.ts
 PASS   Vuetify  src/components/VLazy/__tests__/VLazy.spec.ts
 PASS   Vuetify  src/components/VMessages/__tests__/VMessages.spec.ts
 PASS   Vuetify  src/components/VPicker/__tests__/VPicker.spec.ts
 PASS   Vuetify  src/components/VColorPicker/__tests__/VColorPickerCanvas.spec.ts
 PASS   Vuetify  src/components/VBtnToggle/__tests__/VBtnToggle.spec.ts
 PASS   Vuetify  src/mixins/bootable/__tests__/bootable.spec.ts
 PASS   Vuetify  src/components/VExpansionPanel/__tests__/VExpansionPanels.spec.ts
 PASS   Vuetify  src/components/VTabs/__tests__/VTab.spec.ts
 PASS   Vuetify  src/components/VSystemBar/__tests__/VSystemBar.spec.ts
 PASS   Vuetify  src/components/VList/__tests__/VListItemAction.spec.ts
 PASS   Vuetify  src/components/VDataTable/mixins/__tests__/header.spec.ts
 PASS   Vuetify  src/mixins/applicationable/__tests__/applicationable.spec.ts
 PASS   Vuetify  src/components/VFooter/__tests__/VFooter.spec.ts
 PASS   Vuetify  src/components/VCalendar/mixins/__tests__/mouse.spec.ts
 PASS   Vuetify  src/services/goto/__tests__/goto.spec.ts
 PASS   Vuetify  src/components/VList/__tests__/VList.spec.ts
 PASS   Vuetify  src/components/VGrid/__tests__/VGrid.spec.ts
 PASS   Vuetify  src/components/VApp/__tests__/VApp.spec.ts
 PASS   Vuetify  src/components/VRadioGroup/__tests__/VRadioGroup.spec.ts
 PASS   Vuetify  src/components/VCalendar/mixins/__tests__/times.spec.ts
 PASS   Vuetify  src/components/VCarousel/__tests__/VCarouselItem.spec.ts
 PASS   Vuetify  src/components/VAvatar/__tests__/VAvatar.spec.ts
 PASS   Vuetify  src/components/VTabs/__tests__/VTabsBar.spec.ts
 PASS   Vuetify  src/locale/__tests__/index.spec.ts
 PASS   Vuetify  src/components/VSheet/__tests__/VSheet.spec.ts
 PASS   Vuetify  src/directives/scroll/__tests__/scroll.spec.ts
 PASS   Vuetify  src/services/lang/__tests__/lang.spec.ts
 PASS   Vuetify  src/mixins/detachable/__tests__/detachable.spec.ts
 PASS   Vuetify  src/components/VGrid/__tests__/VContainer.spec.ts
 PASS   Vuetify  src/components/VResponsive/__tests__/VResponsive.spec.ts
diff --git a/packages/vuetify/.eslintrc.js b/packages/vuetify/.eslintrc.js
index 18fd74f2c..60b36bfa8 100644
--- a/packages/vuetify/.eslintrc.js
+++ b/packages/vuetify/.eslintrc.js
@@ -12,7 +12,7 @@ module.exports = {
   ],
   extends: ['plugin:jest/recommended'],
   rules: {
-    'no-console': 'error',
+    'no-console': 'off',
     'no-debugger': 'error',
     'vue/html-self-closing': 'off',
     'vue/html-closing-bracket-spacing': 'off',
diff --git a/packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts b/packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts
index 245463d1f..ee79e1bd7 100644
--- a/packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts
+++ b/packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts
 PASS   Vuetify  src/util/__tests__/dateTimeUtils.spec.ts
 PASS   Vuetify  src/components/VOverlay/__tests__/VOverlay.spec.ts
 PASS   Vuetify  src/components/VGrid/__tests__/VLayout.spec.ts
 PASS   Vuetify  src/mixins/selectable/__tests__/selectable.spec.ts
 PASS   Vuetify  src/services/presets/__tests__/presets.spec.ts
 PASS   Vuetify  src/components/VMain/__tests__/VMain.spec.ts
 PASS   Vuetify  src/components/VDivider/__tests__/VDivider.spec.ts
 PASS   Vuetify  src/mixins/routable/__tests__/routable.spec.ts
 PASS   Vuetify  src/mixins/colorable/__tests__/colorable.spec.ts
 PASS   Vuetify  src/components/VToolbar/__tests__/VToolbar.spec.ts
 PASS   Vuetify  src/mixins/elevatable/__tests__/elevatable.spec.ts
 PASS   Vuetify  src/services/application/__tests__/application.spec.ts
 PASS   Vuetify  src/services/theme/__tests__/theme-utils.spec.ts
 PASS   Vuetify  src/components/VSubheader/__tests__/VSubheader.spec.ts
 PASS   Vuetify  src/components/VTreeview/util/__tests__/filterTreeItems.spec.ts
 PASS   Vuetify  src/mixins/menuable/__tests__/menuable.spec.ts
 PASS   Vuetify  src/components/VList/__tests__/VListItemGroup.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/VVirtualTable.spec.ts
 PASS   Vuetify  src/util/__tests__/console.spec.ts
 PASS   Vuetify  src/components/VThemeProvider/__tests__/VThemeProvider.spec.ts
 PASS   Vuetify  src/util/__tests__/dom.spec.ts
 PASS   Vuetify  src/components/VCalendar/modes/__tests__/common.spec.ts
 PASS   Vuetify  src/mixins/proxyable/__tests__/proxyable.spec.ts
 PASS   Vuetify  src/components/VItemGroup/__tests__/VItem.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/RowGroup.spec.ts
 PASS   Vuetify  src/components/VTabs/__tests__/VTabsSlider.spec.ts
 PASS   Vuetify  src/components/VParallax/__tests__/VParallax.spec.ts
 PASS   Vuetify  src/mixins/dependent/__tests__/dependent.spec.ts
 PASS   Vuetify  src/components/VGrid/__tests__/VFlex.spec.ts
 PASS   Vuetify  src/components/VBreadcrumbs/__tests__/VBreadcrumbsItem.spec.ts
 PASS   Vuetify  src/mixins/rippleable/__tests__/rippleable.spec.ts
 PASS   Vuetify  src/services/icons/__tests__/icons.spec.ts
 PASS   Vuetify  src/components/VList/__tests__/VListItemAvatar.spec.ts
 PASS   Vuetify  src/mixins/intersectable/__tests__/intersectable.spec.ts
 PASS   Vuetify  src/directives/mutate/__tests__/mutate.spec.ts
 PASS   Vuetify  src/components/VTimeline/__tests__/VTimeline.spec.ts
 PASS   Vuetify  src/directives/resize/__tests__/resize.spec.ts
 PASS   Vuetify  src/components/VLabel/__tests__/VLabel.spec.ts
 PASS   Vuetify  src/mixins/roundable/__tests__/roundable.spec.ts
 PASS   Vuetify  src/components/VCheckbox/__tests__/VSimpleCheckbox.spec.ts
 PASS   Vuetify  src/components/VCounter/__tests__/VCounter.spec.ts
 PASS   Vuetify  src/components/VDatePicker/util/__tests__/monthChange.spec.ts
 PASS   Vuetify  src/components/VCalendar/util/__tests__/props.spec.ts
 PASS   Vuetify  src/components/VDatePicker/util/__tests__/pad.spec.ts
 PASS   Vuetify  src/components/VDatePicker/util/__tests__/sanitizeDateString.spec.ts
 PASS   Vuetify  src/services/goto/__tests__/easing-patterns.spec.ts
 PASS   Vuetify  src/components/VDatePicker/util/__tests__/createNativeLocaleFormatter.spec.ts
 PASS   Vuetify  src/directives/intersect/__tests__/intersect.spec.ts

Test Suites: 189 passed, 189 total
Tests:       60 skipped, 1600 passed, 1660 total
Snapshots:   641 passed, 641 total
Time:        35.192 s, estimated 38 s
Ran all test suites.
Done in 36.72s.
  vuetify git:(fix/11767-calendar-midnight-end)  git diff
  vuetify git:(fix/11767-calendar-midnight-end)  git diff
  vuetify git:(fix/11767-calendar-midnight-end)  yarn run test
yarn run v1.22.10
$ node build/run-tests.js
$ cross-env NODE_ENV=test jest
 PASS   Vuetify  src/components/VAppBar/__tests__/VAppBar.spec.ts (5.869 s)
 PASS   Vuetify  src/components/VTimePicker/__tests__/VTimePicker.spec.ts
 PASS   Vuetify  src/services/breakpoint/__tests__/breakpoint.spec.ts
 PASS   Vuetify  src/components/VNavigationDrawer/__tests__/VNavigationDrawer.spec.ts (10.243 s)
 PASS   Vuetify  src/components/VCalendar/util/__tests__/events.spec.ts
 PASS   Vuetify  src/components/VStepper/__tests__/VStepperContent.spec.ts
 PASS   Vuetify  src/components/VDatePicker/__tests__/VDatePicker.date.spec.ts
 PASS   Vuetify  src/components/VSelect/__tests__/VSelect2.spec.ts
 PASS   Vuetify  src/mixins/scrollable/__tests__/scrollable.spec.ts
 PASS   Vuetify  src/mixins/mobile/__tests__/mobile.spec.ts
 PASS   Vuetify  src/components/VDatePicker/__tests__/VDatePicker.month.spec.ts
 PASS   Vuetify  src/components/VMenu/__tests__/VMenu.spec.ts
 PASS   Vuetify  src/components/VCombobox/__tests__/VCombobox-multiple.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/VDataTable.spec.ts (15.946 s)
 PASS   Vuetify  src/components/VAutocomplete/__tests__/VAutocomplete.spec.ts
 PASS   Vuetify  src/components/VSelect/__tests__/VSelect3.spec.ts
 PASS   Vuetify  src/components/VDatePicker/__tests__/VDatePickerDateTable.spec.ts
 PASS   Vuetify  src/components/VAutocomplete/__tests__/VAutocomplete2.spec.ts
 PASS   Vuetify  src/components/VCalendar/__tests__/VCalendarDaily.spec.ts
 PASS   Vuetify  src/components/VAutocomplete/__tests__/VAutocomplete3.spec.ts
 PASS   Vuetify  src/components/VSelect/__tests__/VSelect4.spec.ts
 PASS   Vuetify  src/services/theme/__tests__/theme.spec.ts
 PASS   Vuetify  src/components/VRangeSlider/__tests__/VRangeSlider.spec.ts
 PASS   Vuetify  src/components/VColorPicker/__tests__/VColorPicker.spec.ts
 PASS   Vuetify  src/components/VSelect/__tests__/VSelect.spec.ts
 PASS   Vuetify  src/mixins/overlayable/__tests__/overlayable.spec.ts
 PASS   Vuetify  src/components/VDataIterator/__tests__/VDataIterator.spec.ts
 PASS   Vuetify  src/components/VDialog/__tests__/VDialog.spec.ts
 PASS   Vuetify  src/components/VTimePicker/__tests__/VTimePickerClock.spec.ts
 PASS   Vuetify  src/components/VCheckbox/__tests__/VCheckbox.spec.ts
 PASS   Vuetify  src/components/VPagination/__tests__/VPagination.spec.ts
 PASS   Vuetify  src/components/VCalendar/__tests__/VCalendar.spec.ts
 PASS   Vuetify  src/components/VCombobox/__tests__/VCombobox.spec.ts
 PASS   Vuetify  src/components/VSlider/__tests__/VSlider.spec.ts
 PASS   Vuetify  src/components/VWindow/__tests__/VWindow.spec.ts
 PASS   Vuetify  src/components/VTextField/__tests__/VTextField.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/VDataTableHeader.spec.ts
 PASS   Vuetify  src/components/VHover/__tests__/VHover.spec.ts
 PASS   Vuetify  src/components/VSkeletonLoader/__tests__/VSkeletonLoader.spec.ts
 PASS   Vuetify  src/components/VIcon/__tests__/VIcon.spec.ts
 PASS   Vuetify  src/components/VFileInput/__tests__/VFileInput.spec.ts
 PASS   Vuetify  src/util/__tests__/helpers.spec.ts
 PASS   Vuetify  src/components/VInput/__tests__/VInput.spec.ts
 PASS   Vuetify  src/components/VCalendar/mixins/__tests__/calendar-with-intervals.spec.ts
 PASS   Vuetify  src/components/VProgressLinear/__tests__/VProgressLinear.spec.ts
 PASS   Vuetify  src/components/VImg/__tests__/VImg.spec.ts
 PASS   Vuetify  src/components/VDatePicker/__tests__/VDatePickerMonthTable.spec.ts
 PASS   Vuetify  src/components/VDatePicker/__tests__/VDatePickerHeader.spec.ts
 PASS   Vuetify  src/components/VSlideGroup/__tests__/VSlideGroup.spec.ts
 PASS   Vuetify  src/components/VCalendar/__tests__/VCalendarCategory.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/VEditDialog.spec.ts
 PASS   Vuetify  src/mixins/validatable/__tests__/validatable.spec.ts
 PASS   Vuetify  src/components/VRating/__tests__/VRating.spec.ts
 PASS   Vuetify  src/components/VDataIterator/__tests__/VDataFooter.spec.ts
 PASS   Vuetify  src/components/VCalendar/mixins/__tests__/calendar-with-events.spec.ts
 PASS   Vuetify  src/components/VSwitch/__tests__/VSwitch.spec.ts
 PASS   Vuetify  src/components/VCarousel/__tests__/VCarousel.spec.ts
 PASS   Vuetify  src/components/VTreeview/__tests__/VTreeview.spec.ts
 PASS   Vuetify  src/components/VBanner/__tests__/VBanner.spec.ts
 PASS   Vuetify  src/components/VSnackbar/__tests__/VSnackbar.spec.ts
 PASS   Vuetify  src/components/VSparkline/__tests__/VSparkline.spec.ts
 PASS   Vuetify  src/components/VTimePicker/__tests__/VTimePickerTitle.spec.ts
 PASS   Vuetify  src/components/VGrid/__tests__/VCol.spec.ts
 PASS   Vuetify  src/components/VOverflowBtn/__tests__/VOverflowBtn.spec.ts
 PASS   Vuetify  src/components/VTabs/__tests__/VTabs.spec.ts
 PASS   Vuetify  src/components/VTooltip/__tests__/VTooltip.spec.ts
 PASS   Vuetify  src/components/VDatePicker/__tests__/VDatePickerYears.spec.ts
 PASS   Vuetify  src/components/VAlert/__tests__/VAlert.spec.ts
 PASS   Vuetify  src/components/VItemGroup/__tests__/VItemGroup.spec.ts
 PASS   Vuetify  src/components/VList/__tests__/VListGroup.spec.ts
 PASS   Vuetify  src/directives/ripple/__tests__/ripple.spec.ts
 PASS   Vuetify  src/components/VForm/__tests__/VForm.spec.ts
 PASS   Vuetify  src/components/VBtn/__tests__/VBtn.spec.ts
 PASS   Vuetify  src/components/VBadge/__tests__/VBadge.spec.ts
 PASS   Vuetify  src/components/VTextarea/__tests__/VTextarea.spec.ts
 PASS   Vuetify  src/components/VData/__tests__/VData.spec.ts
 PASS   Vuetify  src/components/VColorPicker/__tests__/VColorPickerEdit.spec.ts
 PASS   Vuetify  src/components/VWindow/__tests__/VWindowItem.spec.ts
 PASS   Vuetify  src/components/VCalendar/util/__tests__/timestamp.spec.ts
 PASS   Vuetify  src/components/VBreadcrumbs/__tests__/VBreadcrumbs.spec.ts
 PASS   Vuetify  src/components/VChip/__tests__/VChip.spec.ts
 PASS   Vuetify  src/components/VSelect/__tests__/VSelectList.spec.ts
 PASS   Vuetify  src/components/VList/__tests__/VListItem.spec.ts
 PASS   Vuetify  src/components/VDatePicker/__tests__/VDatePickerTitle.spec.ts
 PASS   Vuetify  src/components/VCalendar/mixins/__tests__/calendar-base.spec.ts
 PASS   Vuetify  src/components/VStepper/__tests__/VStepperStep.spec.ts
 PASS   Vuetify  src/components/VBottomNavigation/__tests__/VBottomNavigation.spec.ts
 PASS   Vuetify  src/util/__tests__/mergeData.spec.ts
 PASS   Vuetify  src/components/VRadioGroup/__tests__/VRadio.spec.ts
 PASS   Vuetify  src/locale/__tests__/index.spec.ts
 PASS   Vuetify  src/components/VSpeedDial/__tests__/VSpeedDial.spec.ts
 PASS   Vuetify  src/mixins/activatable/__tests__/activatable.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/MobileRow.spec.ts
 PASS   Vuetify  src/components/VProgressCircular/__tests__/VProgressCircular.spec.ts
 PASS   Vuetify  src/components/VTreeview/__tests__/VTreeviewNode.spec.ts
 PASS   Vuetify  src/components/VChipGroup/__tests__/VChipGroup.spec.ts
 PASS   Vuetify  src/components/VCard/__tests__/VCard.spec.ts
 PASS   Vuetify  src/components/VExpansionPanel/__tests__/VExpansionPanel.spec.ts
 PASS   Vuetify  src/mixins/roundable/__tests__/roundable.spec.ts
 PASS   Vuetify  src/services/goto/__tests__/goto.spec.ts
 PASS   Vuetify  src/components/VDataTable/mixins/__tests__/header.spec.ts
 PASS   Vuetify  src/util/__tests__/colorUtils.spec.ts
 PASS   Vuetify  src/components/VList/__tests__/VList.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/Row.spec.ts
 PASS   Vuetify  src/components/VPicker/__tests__/VPicker.spec.ts
 PASS   Vuetify  src/components/VColorPicker/__tests__/VColorPickerPreview.spec.ts
 PASS   Vuetify  src/components/VTabs/__tests__/VTab.spec.ts
 PASS   Vuetify  src/components/VSheet/__tests__/VSheet.spec.ts
 PASS   Vuetify  src/components/VList/__tests__/VListItemGroup.spec.ts
 PASS   Vuetify  src/components/VTabs/__tests__/VTabsBar.spec.ts
 PASS   Vuetify  src/components/VTimeline/__tests__/VTimelineItem.spec.ts
 PASS   Vuetify  src/components/VCheckbox/__tests__/VSimpleCheckbox.spec.ts
 PASS   Vuetify  src/components/VColorPicker/__tests__/VColorPickerCanvas.spec.ts
 PASS   Vuetify  src/components/VThemeProvider/__tests__/VThemeProvider.spec.ts
 PASS   Vuetify  src/components/VLabel/__tests__/VLabel.spec.ts
 PASS   Vuetify  src/directives/color/__tests__/color.spec.ts
 PASS   Vuetify  src/components/VVirtualScroll/__tests__/VVirtualScroll.spec.ts
 PASS   Vuetify  src/components/VRadioGroup/__tests__/VRadioGroup.spec.ts
 PASS   Vuetify  src/directives/click-outside/__tests__/click-outside-shadow-dom.spec.ts
 PASS   Vuetify  src/components/VColorPicker/util/__tests__/index.spec.ts
 PASS   Vuetify  src/components/VStepper/__tests__/VStepper.spec.ts
 PASS   Vuetify  src/components/VBreadcrumbs/__tests__/VBreadcrumbsItem.spec.ts
 PASS   Vuetify  src/mixins/applicationable/__tests__/applicationable.spec.ts
 PASS   Vuetify  src/services/theme/__tests__/theme-utils.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/VSimpleTable.spec.ts
 PASS   Vuetify  src/components/VBtnToggle/__tests__/VBtnToggle.spec.ts
 PASS   Vuetify  src/components/VToolbar/__tests__/VToolbar.spec.ts
 PASS   Vuetify  src/components/VDivider/__tests__/VDivider.spec.ts
 PASS   Vuetify  src/components/VFooter/__tests__/VFooter.spec.ts
 PASS   Vuetify  src/components/VItemGroup/__tests__/VItem.spec.ts
 PASS   Vuetify  src/mixins/detachable/__tests__/detachable.spec.ts
 PASS   Vuetify  src/components/VSubheader/__tests__/VSubheader.spec.ts
 PASS   Vuetify  src/mixins/selectable/__tests__/selectable.spec.ts
 PASS   Vuetify  src/mixins/rippleable/__tests__/rippleable.spec.ts
 PASS   Vuetify  src/components/VMessages/__tests__/VMessages.spec.ts
 PASS   Vuetify  src/mixins/colorable/__tests__/colorable.spec.ts
 PASS   Vuetify  src/components/VOverlay/__tests__/VOverlay.spec.ts
 PASS   Vuetify  src/components/VAvatar/__tests__/VAvatar.spec.ts
 PASS   Vuetify  src/components/VExpansionPanel/__tests__/VExpansionPanelHeader.spec.ts
 PASS   Vuetify  src/directives/scroll/__tests__/scroll.spec.ts
 PASS   Vuetify  src/components/VTimeline/__tests__/VTimeline.spec.ts
 PASS   Vuetify  src/directives/touch/__tests__/touch.spec.ts
 PASS   Vuetify  src/components/VCalendar/mixins/__tests__/mouse.spec.ts
 PASS   Vuetify  src/components/VExpansionPanel/__tests__/VExpansionPanels.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/VVirtualTable.spec.ts
 PASS   Vuetify  src/mixins/routable/__tests__/routable.spec.ts
 PASS   Vuetify  src/directives/resize/__tests__/resize.spec.ts
 PASS   Vuetify  src/mixins/bootable/__tests__/bootable.spec.ts
 PASS   Vuetify  src/mixins/menuable/__tests__/menuable.spec.ts
 PASS   Vuetify  src/components/VAppBar/__tests__/VAppBarNavIcon.spec.ts
 PASS   Vuetify  src/util/__tests__/dateTimeUtils.spec.ts
 PASS   Vuetify  src/mixins/intersectable/__tests__/intersectable.spec.ts
 PASS   Vuetify  src/components/VCalendar/mixins/__tests__/times.spec.ts
 PASS   Vuetify  src/components/VMain/__tests__/VMain.spec.ts
diff --git a/packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts b/packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts
index 245463d1f..ee79e1bd7 100644
--- a/packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts
+++ b/packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts
@@ -26,6 +26,7 @@ import {
   isEventStart,
   isEventOn,
   isEventOverlapping,
+  isEventHiddenOn,
 } from '../util/events'
 import {
   CalendarTimestamp,
@@ -267,7 +268,7 @@ export default CalendarBase.extend({
       })
     },
     genTimedEvent ({ event, left, width }: CalendarEventVisual, day: CalendarDayBodySlotScope): VNode | false {
-      if (day.timeDelta(event.end) <= 0 || day.timeDelta(event.start) >= 1) {
 PASS   Vuetify  src/directives/click-outside/__tests__/click-outside.spec.ts
 PASS   Vuetify  src/components/VCarousel/__tests__/VCarouselItem.spec.ts
 PASS   Vuetify  src/components/VCounter/__tests__/VCounter.spec.ts
 PASS   Vuetify  src/components/VGrid/__tests__/VLayout.spec.ts
 PASS   Vuetify  src/components/VLazy/__tests__/VLazy.spec.ts
 PASS   Vuetify  src/components/VList/__tests__/VListItemAction.spec.ts
 PASS   Vuetify  src/components/VSystemBar/__tests__/VSystemBar.spec.ts
 PASS   Vuetify  src/components/VApp/__tests__/VApp.spec.ts
 PASS   Vuetify  src/components/VTabs/__tests__/VTabsSlider.spec.ts
 PASS   Vuetify  src/components/VGrid/__tests__/VContainer.spec.ts
 PASS   Vuetify  src/util/__tests__/console.spec.ts
diff --git a/packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts b/packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts
index 245463d1f..ee79e1bd7 100644
--- a/packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts
+++ b/packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts
@@ -26,6 +26,7 @@ import {
   isEventStart,
   isEventOn,
   isEventOverlapping,
+  isEventHiddenOn,
 } from '../util/events'
 import {
   CalendarTimestamp,
@@ -267,7 +268,7 @@ export default CalendarBase.extend({
       })
     },
     genTimedEvent ({ event, left, width }: CalendarEventVisual, day: CalendarDayBodySlotScope): VNode | false {
-      if (day.timeDelta(event.end) <= 0 || day.timeDelta(event.start) >= 1) {
 PASS   Vuetify  src/components/VCalendar/modes/__tests__/common.spec.ts
 PASS   Vuetify  src/util/__tests__/dom.spec.ts
 PASS   Vuetify  src/mixins/dependent/__tests__/dependent.spec.ts
 PASS   Vuetify  src/services/lang/__tests__/lang.spec.ts
 PASS   Vuetify  src/mixins/proxyable/__tests__/proxyable.spec.ts
 PASS   Vuetify  src/components/VList/__tests__/VListItemAvatar.spec.ts
 PASS   Vuetify  src/services/presets/__tests__/presets.spec.ts
 PASS   Vuetify  src/components/VDatePicker/util/__tests__/monthChange.spec.ts
 PASS   Vuetify  src/components/VGrid/__tests__/VFlex.spec.ts
 PASS   Vuetify  src/mixins/elevatable/__tests__/elevatable.spec.ts
 PASS   Vuetify  src/components/VParallax/__tests__/VParallax.spec.ts
 PASS   Vuetify  src/directives/mutate/__tests__/mutate.spec.ts
 PASS   Vuetify  src/components/VGrid/__tests__/VGrid.spec.ts
 PASS   Vuetify  src/components/VResponsive/__tests__/VResponsive.spec.ts
 PASS   Vuetify  src/components/VDatePicker/util/__tests__/pad.spec.ts
 PASS   Vuetify  src/components/VTreeview/util/__tests__/filterTreeItems.spec.ts
 PASS   Vuetify  src/directives/intersect/__tests__/intersect.spec.ts
 PASS   Vuetify  src/components/VDataTable/__tests__/RowGroup.spec.ts
 PASS   Vuetify  src/components/VDatePicker/util/__tests__/sanitizeDateString.spec.ts
 PASS   Vuetify  src/services/goto/__tests__/easing-patterns.spec.ts
 PASS   Vuetify  src/services/icons/__tests__/icons.spec.ts
 PASS   Vuetify  src/components/VCalendar/util/__tests__/props.spec.ts
 PASS   Vuetify  src/services/application/__tests__/application.spec.ts
 PASS   Vuetify  src/components/VDatePicker/util/__tests__/createNativeLocaleFormatter.spec.ts

Test Suites: 189 passed, 189 total
Tests:       60 skipped, 1600 passed, 1660 total
Snapshots:   641 passed, 641 total
Time:        33.009 s
Ran all test suites.
Done in 34.55s.
  vuetify git:(fix/11767-calendar-midnight-end)  git status
On branch fix/11767-calendar-midnight-end
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	modified:   src/components/VCalendar/mixins/calendar-with-events.ts
	modified:   src/components/VCalendar/util/__tests__/events.spec.ts
	modified:   src/components/VCalendar/util/events.ts

  vuetify git:(fix/11767-calendar-midnight-end)  git reset
Unstaged changes after reset:
M	packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts
M	packages/vuetify/src/components/VCalendar/util/__tests__/events.spec.ts
fix(VCalendar): display events ending at midnight

fixes: vuetifyjs#11767 & vuetifyjs#12223
whg added a commit to whg/vuetify that referenced this issue May 17, 2021
@whg
fix(VCalendar): display events ending at midnight
9272a37 
fixes: vuetifyjs#11767 & vuetifyjs#12223
@whg whg mentioned this issue May 17, 2021
Merged
8 tasks
whg added a commit to whg/vuetify that referenced this issue May 18, 2021
@whg
fix(VCalendar): display events ending at midnight
13d1510 
fixes: vuetifyjs#11767 & vuetifyjs#12223
added tests
@KaelWD KaelWD added C: VCalendar VCalendar T: bug Functionality that does not work as intended/expected and removed S: triage labels Jun 1, 2021
@KaelWD KaelWD assigned KaelWD and unassigned ClickerMonkey Jun 1, 2021
@KaelWD KaelWD added this to the v2.5.x milestone Jun 1, 2021
KaelWD pushed a commit that referenced this issue Jun 1, 2021
@whg
fix(VCalendar): display events ending at midnight (#13667)
9a48b0f 
fixes #11767
fixes #12223
@KaelWD KaelWD mentioned this issue Jun 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaelWD KaelWD

Labels
C: VCalendar VCalendar T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.5.x
Development

Successfully merging a pull request may close this issue.

fix(VCalendar): display events ending at midnight whg/vuetify
7 participants
@ClickerMonkey @fdebiesse @DaanSterk @TheOnlyError @dbettini @KaelWD @Jaykob86