Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VBtnToggle): add missing RTL support in button groups #11849

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

IwalkAlone
Copy link
Contributor

Description

Make sure that when using VBtnToggle in RTL mode with rounded corners, the correct corners are rounded for the first and last item, and borders are displayed correctly (no missing or doubled borders).

Fixes #11793

Motivation and Context

Fixes #11793

How Has This Been Tested?

visually

Markup:

<template>
  <v-btn-toggle rounded>
    <v-btn>
      <v-icon>mdi-format-align-left</v-icon>
    </v-btn>
    <v-btn>
      <v-icon>mdi-format-align-center</v-icon>
    </v-btn>
    <v-btn>
      <v-icon>mdi-format-align-right</v-icon>
    </v-btn>
    <v-btn>
      <v-icon>mdi-format-align-justify</v-icon>
    </v-btn>
  </v-btn-toggle>
</template>

<script>
export default {
  data: () => ({}),
  mounted() {
    this.$vuetify.rtl = true;
  },
};
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

Fix the wrong side rounded corners and doubled border in RTL mode.

fix vuetifyjs#11793
@jacekkarczmarczyk jacekkarczmarczyk added C: VBtnToggle VBtnToggle T: bug Functionality that does not work as intended/expected labels Jul 13, 2020
Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KaelWD KaelWD merged commit 75f2bf3 into vuetifyjs:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VBtnToggle VBtnToggle T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Vuetify v-btn-toggle rtl is not working
3 participants