Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal v-dialog inside v-data-table cell not working anymore since 0.14.8 #1233

Closed
smxsm opened this issue Aug 3, 2017 · 5 comments
Closed
Assignees
Labels
T: bug Functionality that does not work as intended/expected

Comments

@smxsm
Copy link

smxsm commented Aug 3, 2017

With release 0.14.8., modal dialog buttons inside data table cells stopped working, it works fine if I go back to 0.14.7.

Steps to reproduce

Add a dialog element to a datatable cell and try clicking it.
Here is a codepen example, if you click on any of the buttons, nothing happens any more: https://codepen.io/beffy72/pen/OjbJOp
There is no error, and the Vue console says the button is firing an event, but it seems the data table now "sucks it up" somehow... :(

Versions

Vuetify 0.14.8, VueJS 2.4.2

What is expected ?

A modal dialog should appear.

What is actually happening ?

No dialog appears.

Reproduction Link

https://codepen.io/beffy72/pen/OjbJOp

@Producdevity
Copy link

Got the same issue..

@johnleider johnleider added pending review The issue is still pending disposition T: bug Functionality that does not work as intended/expected and removed pending review The issue is still pending disposition labels Aug 3, 2017
@johnleider johnleider self-assigned this Aug 4, 2017
@karlyao
Copy link

karlyao commented Feb 25, 2018

Hi, is this bug re-surfaced in V1.0.3?

@johnleider
Copy link
Member

johnleider commented Feb 25, 2018 via email

@mizzao
Copy link

mizzao commented Apr 3, 2018

@smxsm btw, that doesn't seem to be the proper way to display a v-dialog inside a v-data-table. Because you are editing the global dialog, it's actually creating 1 dialog for each entry in the data table, or 5-10 dialogs in your case. Shouldn't you be setting props.dialog instead?

@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

5 participants