Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Ratings props.isHovered isn't working #12629

Closed
MariaNicolosi opened this issue Nov 16, 2020 · 2 comments
Closed

[Bug Report] Ratings props.isHovered isn't working #12629

MariaNicolosi opened this issue Nov 16, 2020 · 2 comments
Assignees
@nekosaur @johnleider
Labels
C: VRating VRating T: bug Functionality that does not work as intended/expected
Projects
Vuetify 3 - Titan
Milestone
v3.0.0

Comments

@MariaNicolosi
Copy link

Environment

Vuetify Version: 2.3.17
Vue Version: 2.6.12
Browsers: Chrome 86.0.4240.183
OS: Mac OS 10.15.7

Steps to reproduce

Try to access the isHovered prop in the v-ratings item slot.

Expected Behavior

isHovered should be true with the icon is hovered

Actual Behavior

the isHovered prop value does not change

Reproduction Link

https://codepen.io/marianicolosi/pen/dyXrmEj?editors=1111
@nekosaur
Copy link
Member

ah, we're not passing the listeners to the scope so that they can be attached.

@ElijahKotyluk ElijahKotyluk added the C: VRating VRating label Jun 24, 2021
@johnleider johnleider added this to the v3.0.0 milestone Jun 28, 2021
@johnleider johnleider added this to To do in Vuetify 3 - Titan via automation Jun 28, 2021
@johnleider johnleider added T: bug Functionality that does not work as intended/expected and removed S: triage labels Jun 28, 2021
@johnleider johnleider mentioned this issue Jun 28, 2021
Merged
8 tasks
johnleider pushed a commit that referenced this issue Jun 28, 2021
@nekosaur
feat(VRating): port to v3 (#13410)
0d72164 
fixes #12629
Co-authored-by: John Leider <john.j.leider@gmail.com>
Co-authored-by: Kael <kaelwd@gmail.com>
Co-authored-by: Jacek Karczmarczyk <jk@drukcd.pl>
@johnleider
Copy link
Member

fixed by #13410

If you have any questions, please reach out to us in our Discord community.

Vuetify 3 - Titan automation moved this from To do to Done Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nekosaur nekosaur

@johnleider johnleider

Labels
C: VRating VRating T: bug Functionality that does not work as intended/expected
Projects
No open projects
Vuetify 3 - Titan
Done
Milestone
v3.0.0
Development

No branches or pull requests
5 participants
@nekosaur @johnleider @MariaNicolosi @ElijahKotyluk @MajesticPotatoe