fix(grid): don't halve gutters between v-rows

[KaelWD]

fixes #12915

Markup:

<template>
  <v-container>
    <v-row dense>
      <v-col cols="8">
        <v-card height="100%"></v-card>
      </v-col>
      <v-col cols="4">
        <v-row dense>
          <v-col cols="12">
            <v-card>
              <v-skeleton-loader type="article" />
            </v-card>
          </v-col>
          <v-col cols="12">
            <v-card>
              <v-skeleton-loader type="article" />
            </v-card>
          </v-col>
        </v-row>
      </v-col>
    </v-row>
    <v-row dense>
      <v-col
        v-for="i in 6"
        :key="i"
        cols="6"
      >
        <v-card>
          <v-skeleton-loader type="article" />
        </v-card>
      </v-col>
    </v-row>
  </v-container>
</template>

Types of changes

• Bug fix (non-breaking change which fixes an issue)

[Shinigami92]

Any news about this PR?
Is there anything I can do to help get this fix released?

[KaelWD]

@vuetifyjs/core-team Nobody reviewed this, if it's broken it's your fault.

[Shinigami92]

@vuetifyjs/core-team Nobody reviewed this, if it's broken it's your fault.

lol...

Today (18:26 GMT+2) I'm to tired and wont test it
But I will let you know tomorrow after updating and use with a production environment
So you may hear from me in about the next 24 hours 🙂
Good night o/

[Shinigami92]

... or if it's possible for you, I could also try a beta release 🤔
Like 2.4.3-beta.1

---

Edit: waiting for the next release
Will then report back to you

[vmihailenco]

I can confirm that this is broken.

[Shinigami92]

I just arrived at my working station, will test it now

[Shinigami92]

2.3.23

2.4.3

LGTM

I just removed the pt-0 and pb-0 from my v-cols and don't need any ps or ms in my grid anymore

Just noticed that it moved 4px up, but I think that is intended!

---

@vmihailenco Could you provide a little bit more information about what is broken for you?
Maybe open a new issue and/or link it here

[vmihailenco]

@Shinigami92 does this fixes everyting for you "This is just one breaking example and I would have around 80 more files to check with maybe some more complex layout issues."?

This does not fixes the regressions I have in v2.4.x and additionally breaks margin-top, e.g. v-row dense class="mt-4".

[Shinigami92]

This was just the same example as I showed in #12915
That's why I send it here

But many more sites worked the same for me

Yeah it's a breaking change from 2.3 to 2.4, but this 2.4.3 is the fixed version 2.4 where I think I can finally migrate to 2.4
But I encountered another issue with v-text-field and label+placeholder, but I will search if anyone else has already reported it or open a new one, but this is not related to this issue/pr/fix
=> I found the already opened issue: #12839

I have encountered a part where I have a custom created component where I need to add my-0, but that's totally fine for me because it is a self made component and the "workaround" just worked

Checking more files now
I currently was half way trough my tool :D

[Shinigami92]

Ok, so I think I have visited almost all pages in our tool and it looks a bit more slimmer to me
That's the 4px less at the top (and so I also think at the bottom?)

2.3.23

2.4.3

---

So I can even think about that this change was indeed intended
And so I'm fine with this
Or in other words, this fix fixed more that it broke for me 🙂

@vmihailenco If you encountered other problems, please open a new issue and we can try to work on that
Screenshots of your problems could also help