Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Clearing autocomplete using backspace not working #12958

Closed
Djaler opened this issue Jan 14, 2021 · 3 comments · Fixed by #13152, gigili/good-food-tracker-web#98, elirehema/nbs-web#87, elirehema/authx#10 or accentor/web#457
Labels
C: VAutocomplete VAutocomplete T: bug Functionality that does not work as intended/expected
Milestone

Comments

@Djaler
Copy link
Contributor

Djaler commented Jan 14, 2021

Environment

Vuetify Version: 2.4.2
Last working version: 2.3.17
Vue Version: 2.6.12
Browsers: Chrome 87.0.4280.141
OS: Linux x86_64

Steps to reproduce

  1. Select any item
  2. Try to clear using backspace

Expected Behavior

Value cleared

Actual Behavior

Value not cleared

Reproduction Link

https://codepen.io/djaler/pen/ZEpmazq

Other comments

Looks like it was broken here f1b621b

@ghost ghost added the S: triage label Jan 14, 2021
@Djaler
Copy link
Contributor Author

Djaler commented Jan 16, 2021

@KaelWD hello

@MajesticPotatoe
Copy link
Member

Behavior looks the same even back on v2.0.0 and in v1.5.x. Can you provide an example where its working as intended, or are there possibly reproduction steps missing?

@Djaler
Copy link
Contributor Author

Djaler commented Jan 16, 2021

https://codepen.io/djaler/pen/yLaGQKx this is the same code but with 2.3.17

Also, more detailed steps:

  1. Open autocomplete by click on it
  2. Select any item
  3. Click anywhere else to remove focus from autocomplete
  4. Open autocomplete by click on it again
  5. Press backspace first time -> search will be cleared
  6. Press backspace second time -> autocomplete value will be cleared

https://github.com/vuetifyjs/vuetify/blob/f1b621b3c400ef18c233850a1583ec0d0fa9f0ff/packages/vuetify/src/components/VAutocomplete/VAutocomplete.ts#L236:L255 that's the code

@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected and removed S: needs more information labels Jan 16, 2021
@MajesticPotatoe MajesticPotatoe added this to the v2.4.x milestone Jan 16, 2021
Djaler added a commit to Djaler/vuetify that referenced this issue Feb 25, 2021
…ring

It should be counted in that way in VCombobox, but not in VAutocomplete

fixes vuetifyjs#12958
KaelWD pushed a commit that referenced this issue Mar 6, 2021
It should be counted in that way in VCombobox, but not in VAutocomplete

fixes #12958
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment