Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Regression in VSlider - it sends change events twice, if dragged. #13151

Closed
ldantonov opened this issue Feb 25, 2021 · 1 comment · Fixed by #13222, gigili/good-food-tracker-web#98, elirehema/nbs-web#87, elirehema/authx#10 or accentor/web#457
Assignees
Labels
C: VSlider VSlider T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Milestone

Comments

@ldantonov
Copy link

Environment

Vuetify Version: 2.4.4
Last working version: 2.3.10
Vue Version: 2.6.12
Browsers: Firefox 85.0
OS: Windows 10

Steps to reproduce

Drag the slider by grabbing the thumb and release - in the console you will see the value being reported twice from the change event.
It can also be verified in Vue Dev Tools with a full project. The repeated events include mouseup, end and change.

Expected Behavior

When the thumb is release there should only be one change event emitted.

Actual Behavior

Two change events are emitted when releasing the thumb.

Reproduction Link

https://codepen.io/lantonov/pen/poNpwYg

Other comments

2.3.10 is the last version I've verified, but the change seems to be linked with a code change to VSlider.ts from Dec 2020.

@ghost ghost added the S: triage label Feb 25, 2021
@KaelWD KaelWD added C: VSlider VSlider T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke and removed S: triage labels Feb 28, 2021
@KaelWD
Copy link
Member

KaelWD commented Feb 28, 2021

#12640

@KaelWD KaelWD self-assigned this Mar 6, 2021
@KaelWD KaelWD added this to the v2.4.x milestone Mar 6, 2021
KaelWD added a commit that referenced this issue Mar 6, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment