Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VAutocomplete): don't count search as dirty if it is empty #13152

Merged

Conversation

Djaler
Copy link
Contributor

@Djaler Djaler commented Feb 25, 2021

Description

fixes #12958

Motivation and Context

The issue is regression after #12415
Search should not be counted as dirty when empty string in VCombobox, but not in VAutocomplete

How Has This Been Tested?

Visually on the markup from #12958 (https://codepen.io/djaler/pen/ZEpmazq) and from #12322 (https://codepen.io/MatthewAry/pen/BaKgBNq)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

…ring

It should be counted in that way in VCombobox, but not in VAutocomplete

fixes vuetifyjs#12958
@KaelWD KaelWD merged commit 28d1726 into vuetifyjs:master Mar 6, 2021
This was referenced Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Clearing autocomplete using backspace not working
2 participants