Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSlider): only emit a single change event #13222

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Mar 6, 2021

fixes #13151 (regression from #12640)

onSliderMouseDown was being bound to two elements so the event listeners would be triggered twice

Markup:

<template>
  <v-app>
    <v-container>
      <v-slider @change="onChange"></v-slider>
      <v-range-slider @change="onChange"></v-range-slider>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    methods: {
      onChange (e) {
        console.log(e)
      },
    },
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

@KaelWD KaelWD self-assigned this Mar 6, 2021
@KaelWD KaelWD added C: VSlider VSlider T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke labels Mar 6, 2021
@KaelWD KaelWD added this to the v2.4.x milestone Mar 6, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VSlider VSlider T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Regression in VSlider - it sends change events twice, if dragged.
3 participants