Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VRating): port to v3 #13410

Merged
merged 35 commits into from Jun 28, 2021
Merged

feat(VRating): port to v3 #13410

merged 35 commits into from Jun 28, 2021

Conversation

nekosaur
Copy link
Member

@nekosaur nekosaur commented Apr 11, 2021

Description

Updated v-rating for v3.

Motivation and Context

v3

Breaking changes

  • Added tag prop
  • Added item-labels, item-label-position props and item-label slot ([Feature Request] add label prop to v-rating #5167)
  • Renamed icon-label to item-aria-label
  • Renamed rating.ariaLabel.icon to rating.ariaLabel.item entry in localization files
  • Removed dense prop, added density prop
  • Removed individual size props, added size prop
  • item slot props have changed

How Has This Been Tested?

Markup:

<template>
  <v-app>
    <v-rating
      v-model="rating"
      background-color="purple-lighten-3"
      color="purple"
      size="large"
      hover
      length="10"
    ></v-rating>
    {{ rating }}
  </v-app>
</template>

<script>
  import { ref } from 'vue'

  export default {
    name: 'Playground',
    setup () {
      const rating = ref()

      return { rating }
    },
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@nekosaur nekosaur self-assigned this Apr 11, 2021
@nekosaur nekosaur added this to In progress in Vuetify 3 - Titan via automation Apr 11, 2021
@nekosaur nekosaur added this to the v3.0.0 milestone Apr 11, 2021
@nekosaur nekosaur marked this pull request as ready for review April 21, 2021 19:50
Vuetify 3 - Titan automation moved this from In progress to Review in progress Apr 23, 2021
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for the hover effects (which may be a v-btn thing), they feel delayed/laggy.

rating

@johnleider
Copy link
Member

Requesting Final comments from @vuetifyjs/core-team

Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Components that have a default color should define it as a sass variable with the prop being used to override that.

v-btn default icon styles changed, they now have elevation that should be removed.

packages/vuetify/src/components/VRating/VRating.tsx Outdated Show resolved Hide resolved
packages/vuetify/src/components/VRating/VRating.tsx Outdated Show resolved Hide resolved
Vuetify 3 - Titan automation moved this from Review in progress to Reviewer approved Jun 26, 2021
this brings it in line with other components. it has a color state
and an active-color state. If an active color isn't provided, color
is assumed
@johnleider johnleider merged commit 0d72164 into next Jun 28, 2021
Vuetify 3 - Titan automation moved this from Reviewer approved to Done Jun 28, 2021
@johnleider johnleider deleted the feat/v3-rating branch June 28, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VRating VRating T: feature A new feature
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants