New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VRating): port to v3 #13410
feat(VRating): port to v3 #13410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ec57b11
to
f800ec6
Compare
Requesting Final comments from @vuetifyjs/core-team |
9bb9452
to
4f46d31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Components that have a default color should define it as a sass variable with the prop being used to override that.
v-btn
default icon styles changed, they now have elevation that should be removed.
b943931
to
87d0a05
Compare
dd7e603
to
b2ed5b3
Compare
fad2661
to
4ba2f8a
Compare
this brings it in line with other components. it has a color state and an active-color state. If an active color isn't provided, color is assumed
Description
Updated v-rating for v3.
Motivation and Context
v3
Breaking changes
tag
propitem-labels
,item-label-position
props anditem-label
slot ([Feature Request] add label prop to v-rating #5167)icon-label
toitem-aria-label
rating.ariaLabel.icon
torating.ariaLabel.item
entry in localization filesdense
prop, addeddensity
propsize
propitem
slot props have changedHow Has This Been Tested?
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).