Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs not position correcly when used with fixed toolbar or navigation drawer #1462

Closed
lucafaggianelli opened this issue Aug 25, 2017 · 6 comments
Labels
T: enhancement Functionality that enhances existing features

Comments

@lucafaggianelli
Copy link

lucafaggianelli commented Aug 25, 2017

Steps to reproduce

Use Vuetify v-tabs component together with a fixed toolbar or a navigation drawer: v-tabs is not positioned correctly. Is there any workaround?

Versions

vue: 2.4.2
vuetify: 0.14.7

What is expected ?

When using tabs with fixed toolbar inside, I expect the tabs to be fixed too and to sits below the toolbar, but it shows behind the toolbar and there is no "fixed" prop for tabs (actualy there is but has a different meaning). Same happens when using a navigation drawer: it overlaps the tabs bar on the left or right.

What is actually happening ?

Tabs bar is hidden behind the fixed toolbar and even if fixing the

Reproduction Link

Fixed toolbar:
https://codepen.io/lucafaggianelli/pen/jLpogJ

Navigation drawer:
https://codepen.io/lucafaggianelli/pen/xLJoKO

Tabs bar is based on docs example # 6

@lucafaggianelli
Copy link
Author

Thank you it works, though is not integrated like in example 6 and 7 of the docs https://vuetifyjs.com/components/tabs Well probably playing with CSS I can make it similar, but it seems to me that tabs are not compatible with fixed toolbar

@johnleider
Copy link
Member

I'm not if this is a bug or a question, quickly looking at the markup it seems a bit weird that the toolbar and the navigation drawer are inside of the tabs component, it's definitely not meant for that. If you are looking to place tabs into the toolbar, it should be inside of the component.

@johnleider
Copy link
Member

@lucafaggianelli
Copy link
Author

Yes I'm not sure myself if question or bug.
Wow thank you, your solution is perfect, just what I was trying to achieve! Anyway consider that the doc states to put the toolbar inside tabs, quite weird to me, if it's not correct please can you update the docs?

@johnleider
Copy link
Member

I'll take a look at the examples.

@johnleider johnleider added the pending review The issue is still pending disposition label Aug 27, 2017
@johnleider johnleider added T: enhancement Functionality that enhances existing features and removed pending review The issue is still pending disposition labels Aug 27, 2017
@lock
Copy link

lock bot commented Apr 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: enhancement Functionality that enhances existing features
Projects
None yet
Development

No branches or pull requests

2 participants