Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VCombobox): port to v3 #14791

Merged
merged 36 commits into from
Mar 16, 2022
Merged

feat(VCombobox): port to v3 #14791

merged 36 commits into from
Mar 16, 2022

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Mar 4, 2022

Description

Ports v-combobox to v3 with a separate implementation from v-autocomplete. In the future, v-autocomplete will be updated to use this component as it's base.

Fixes #4679
Fixes #13091

Markup:

<template>
  <v-app>
    <v-main>
      <div class="ma-4 pa-4">
        <v-combobox
          v-model="combobox"
          label="Combobox 1"
          :items="items"
          autocomplete="new-password"
        />
        <v-combobox
          v-model="combobox"
          color="primary"
          label="Combobox 2"
          :items="items"
        />
        <v-combobox
          v-model="combobox"
          bg-color="primary"
          label="Combobox 3"
          :items="items"
        />

        <v-text-field
          v-model="combobox2"
          label="Text field"
          :items="items"
        />
        <v-select
          label="Select"
          :items="items"
        />
        <v-autocomplete
          v-model="combobox2"
          label="Autocomplete"
          :items="items"
        />
      </div>

      <br>
      <br>
      <br>
      <br>
      <br>
      <br>

      <pre>{{ { combobox, combobox2 } }}</pre>
    </v-main>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'

  const textfield = ref('')
  const combobox = ref('')
  // const combobox = ref(['foo', 'bar', 'fizz'])
  const combobox2 = ref('')
  const items = ['foo', 'bar', 'fizz', 'buzz', 'foobar']
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

johnleider and others added 25 commits March 8, 2022 16:22
opt for this instead of hacky setTimeout
@johnleider johnleider marked this pull request as ready for review March 16, 2022 00:29
@johnleider johnleider self-assigned this Mar 16, 2022
@johnleider johnleider added this to the v3.0.0-beta milestone Mar 16, 2022
@KaelWD KaelWD modified the milestones: v3.0.0-beta, v3.0.0 Mar 16, 2022
@johnleider johnleider merged commit 4a9eda9 into next Mar 16, 2022
@johnleider johnleider deleted the feat/v3-combobox-remix branch March 16, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants