Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VRadioGroup): remove multiple prop #15910

Merged
merged 1 commit into from Oct 17, 2022

Conversation

jacekkarczmarczyk
Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk commented Oct 16, 2022

Description

Removes multiple prop

There are some other props that are passed as attr to VSelectionControlGroup (density, error, ripple, valuecomparator), not sure if they should just be removed from props or somehow handled

image

Motivation and Context

fixes #15559

How Has This Been Tested?

yarn test + apigen

Markup

<template>
  <v-main>
    <v-radio-group multiple>
      <v-radio value="1" label="1" />
      <v-radio value="2" label="2" />
    </v-radio-group>
  </v-main>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added the C: VRadioGroup VRadioGroup label Oct 16, 2022
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Oct 16, 2022
@jacekkarczmarczyk jacekkarczmarczyk marked this pull request as draft October 16, 2022 20:48
@jacekkarczmarczyk jacekkarczmarczyk marked this pull request as ready for review October 16, 2022 20:57
@jacekkarczmarczyk jacekkarczmarczyk force-pushed the fix/#15559-v-radio-group-reduntant-props branch from b5df751 to b13ef07 Compare October 16, 2022 20:57
@KaelWD
Copy link
Member

KaelWD commented Oct 17, 2022

I kinda hate this but everything else I can think of is even worse

other props

Should probably be added to VSelectionControlGroup and provided like the radio props are

@KaelWD KaelWD merged commit 32cb6ba into next Oct 17, 2022
@KaelWD KaelWD deleted the fix/#15559-v-radio-group-reduntant-props branch October 17, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VRadioGroup VRadioGroup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants