Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.0.0] V-Autocomplete pre selected option not working when using return-object prop #16046

Closed
ThomasCarbon opened this issue Nov 8, 2022 · 4 comments
Closed

[Bug Report][3.0.0] V-Autocomplete pre selected option not working when using return-object prop #16046

ThomasCarbon opened this issue Nov 8, 2022 · 4 comments
Assignees
@johnleider
Labels
C: VAutocomplete VAutocomplete C: VCombobox VCombobox C: VSelect VSelect T: bug Functionality that does not work as intended/expected
Milestone
v3.0.x

Comments

@ThomasCarbon
Copy link

Environment

Vuetify Version: 3.0.0
Vue Version: 3.2.41
Browsers: Firefox 106.0
OS: Ubuntu undefined

Steps to reproduce

Click v-autocomplete field and see there is no option pre selected while vmodel isnt empty.
Remove return object prop and see it working

Expected Behavior

Make pre selected option work properly when using filled vmodel and return object prop

Actual Behavior

Pre selected option doest not work when using filled vmodel and return object prop

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

Thanks Andrew for your help on discord. He said himself its a bug
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VSelect VSelect C: VCombobox VCombobox C: VAutocomplete VAutocomplete and removed S: triage labels Nov 8, 2022
@KaelWD KaelWD added this to the v3.0.x milestone Nov 8, 2022
@evans23

This comment was marked as resolved.

Sign in to view
@ThomasCarbon
Copy link
Author

@evans23, i do not have this issue at all, i think its a problem on your side, try to post a playvuetify about it

@evans23
Copy link

evans23 commented Nov 14, 2022

@ThomasCarbon Yep, you appear to be correct!

vexleet added a commit to vexleet/vuetify that referenced this issue Nov 17, 2022
@vexleet
fix(v-autocomplete): add preselected options with return-object
87145cf 
In the selections computed property the values were checked by using strict equality (triple =),
because of that it couldnt find the correct items and we didnt have preselected options. I added
deepEqual from @utils in order to properly check for equality between the items.

fix vuetifyjs#16046
@vexleet vexleet mentioned this issue Nov 17, 2022
Merged
8 tasks
@ThomasCarbon
Copy link
Author

@vexleet You'r a goat. Thanks for the PR

@johnleider johnleider self-assigned this Nov 29, 2022
johnleider added a commit that referenced this issue Dec 12, 2022
@vexleet @KaelWD @johnleider
fix(VAutocomplete/VCombobox/VSelect): return-object comparison (#16114)
74f7601 
fixes #16046

Co-authored-by: Kael <kaelwd@gmail.com>
Co-authored-by: John Leider <john@vuetifyjs.com>
@ThomasCarbon ThomasCarbon mentioned this issue Dec 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
C: VAutocomplete VAutocomplete C: VCombobox VCombobox C: VSelect VSelect T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.0.x
Development

No branches or pull requests
4 participants
@johnleider @KaelWD @evans23 @ThomasCarbon