Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.1.3] Invalid style of components using 'tools.{ltr,rtl}()' without locale set #16586

Closed
damiankoper opened this issue Feb 3, 2023 · 0 comments · Fixed by #17518
Closed

[Bug Report][3.1.3] Invalid style of components using 'tools.{ltr,rtl}()' without locale set #16586

damiankoper opened this issue Feb 3, 2023 · 0 comments · Fixed by #17518
Assignees
@KaelWD
Labels
framework Issues and Feature Requests that have needs framework-wide. rtl T: bug Functionality that does not work as intended/expected
Milestone
v3.2.x

Comments

@damiankoper
Copy link
Contributor

Environment

Vuetify Version: 3.1.3
Vue Version: 3.2.47
Browsers: Chrome 109.0.0.0
OS: Linux x86_64

Steps to reproduce

Since VApp is now optional I assume that most components can exist without wrappers. An example of that is VTextField. When variant=outlined this component should have its border-radius set to divs with classes v-field__outline__{start, end}. But this style depends on locale (selector .v-locale--is-{rtl,ltr}. When component is not wrapped in VApp or VLocaleProvider these classes are not set and corners are not rounded.

Expected Behavior

Style defaults to ltr when no locale wrapper set

Actual Behavior

No classes applied when no locale wrapper set

Reproduction Link

https://play.vuetifyjs.com/#...
@KaelWD KaelWD mentioned this issue Mar 20, 2023
Closed
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected framework Issues and Feature Requests that have needs framework-wide. rtl and removed S: triage labels Mar 20, 2023
@KaelWD KaelWD added this to the v3.x.x milestone Mar 20, 2023
This was referenced Apr 14, 2023
Closed
Closed
@KaelWD KaelWD mentioned this issue May 3, 2023
Closed
@KaelWD KaelWD self-assigned this May 3, 2023
@KaelWD KaelWD modified the milestones: v3.x.x, v3.2.x May 3, 2023
@KaelWD KaelWD closed this as completed in bc0436d May 3, 2023
This was referenced May 25, 2023
Closed
Closed
@damiankoper damiankoper mentioned this issue Jun 1, 2023
Merged
johnleider pushed a commit that referenced this issue Jun 27, 2023
@damiankoper
fix(VSliderThumb): add missing rtl class (#17518)
d9cec08 
fixes #16586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaelWD KaelWD

Labels
framework Issues and Feature Requests that have needs framework-wide. rtl T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.2.x
Development

Successfully merging a pull request may close this issue.

fix(VSliderThumb): add rtl class damiankoper/vuetify
2 participants
@KaelWD @damiankoper