Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.2.4] Cryptic TS error when passing generic values to v-autocomplete/v-select #17383

Closed
Hawxy opened this issue May 15, 2023 · 2 comments
Closed

[Bug Report][3.2.4] Cryptic TS error when passing generic values to v-autocomplete/v-select #17383

Hawxy opened this issue May 15, 2023 · 2 comments
Assignees
@KaelWD
Labels
C: VAutocomplete VAutocomplete C: VCombobox VCombobox C: VSelect VSelect T: bug Functionality that does not work as intended/expected typescript
Milestone
v3.3.0 (Icarus)

Comments

@Hawxy
Copy link

Hawxy commented May 15, 2023

Environment

Vuetify Version: 3.2.4
Vue Version: 3.3.2
Browsers: Edge 113.0.1774.42
OS: Windows 10

Steps to reproduce

Create a wrapper around selection components that uses Vue 3.3 generics.

Expected Behavior

It works

Actual Behavior

V-Autocomplete: Type 'T | undefined' is not assignable to type 'Val$2<T, false> | null | undefined'.

V-Select: Type 'T' is not assignable to type 'Val<T, false> | null | undefined'

Reproduction Link

https://gist.github.com/Hawxy/d26740e2dd0e4c375f005badea107472
@KaelWD

This comment was marked as outdated.

Sign in to view
@KaelWD KaelWD marked this as a duplicate of #17361 May 15, 2023
@KaelWD KaelWD closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
@KaelWD KaelWD added the duplicate The issue has already been reported label May 15, 2023
@KaelWD KaelWD reopened this May 16, 2023
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VSelect VSelect C: VCombobox VCombobox C: VAutocomplete VAutocomplete typescript and removed duplicate The issue has already been reported labels May 16, 2023
@KaelWD KaelWD self-assigned this May 16, 2023
@KaelWD
Copy link
Member

KaelWD commented May 16, 2023

Apparently this was a breaking change in ts 4.5: microsoft/TypeScript#46429 (comment)

@KaelWD KaelWD added this to the v3.3.0 (Icarus) milestone May 16, 2023
KaelWD added a commit that referenced this issue May 16, 2023
@KaelWD
fix(VSelect): avoid distributive conditional type with unbound generic
5bdcfde 
fixes #17383
@MelvinFrohike MelvinFrohike mentioned this issue Sep 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaelWD KaelWD

Labels
C: VAutocomplete VAutocomplete C: VCombobox VCombobox C: VSelect VSelect T: bug Functionality that does not work as intended/expected typescript
Projects
None yet
Milestone
v3.3.0 (Icarus)
Development

No branches or pull requests
2 participants
@Hawxy @KaelWD