Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.5.14] autocomplete="new-password" doesn't work well with chrome autofill when editing #19559

Open
tongxuanbao opened this issue Apr 8, 2024 · 5 comments · May be fixed by #19572
Open

[Bug Report][3.5.14] autocomplete="new-password" doesn't work well with chrome autofill when editing #19559

tongxuanbao opened this issue Apr 8, 2024 · 5 comments · May be fixed by #19572
Labels
S: triage

Comments

@tongxuanbao
Copy link

tongxuanbao commented Apr 8, 2024 •
edited

Environment

Vuetify Version: 3.5.14
Vue Version: 3.4.21
Browsers: Chrome 123.0.0.0
OS: Windows 10

Steps to reproduce

<VForm>
	<VTextField
		label="Password"
		name="password"
		autocomplete="new-password"
		type="password"
		v-model={form.password.value}
	/>
	<VTextField
		label="Confirm Password"
		name="confirmPassword"
		autocomplete="new-password"
		type="password"
		v-model={form.confirmPassword.value}
	/>
</VForm>

Expected Behavior

With the form above, after using google's password suggestion, editing the first password field would subsequently update the second field without jump to the second field.

Actual Behavior

Everytime we change the first field, focus jumps to the second one.

Reproduction Link

https://github.com/tongxuanbao/vue-project-example

Go to About route and check out the issue
@KaelWD
Copy link
Member

KaelWD commented Apr 8, 2024

Does it do the same if you use <input> there instead?

@tongxuanbao
Copy link
Author

tongxuanbao commented Apr 8, 2024 •
edited

It's working fine with input.
I'm on my phone so can't create a side by side example, but here's an example of input in codepen from my colleague @Maxim-Mazurok https://codepen.io/diegoleme/pen/qBpyvr

tongxuanbao added a commit to tongxuanbao/vuetify that referenced this issue Apr 9, 2024
@tongxuanbao
fix(VTextField): new-password doesn't behave correctly on chrome
82eb538 
fixes vuetifyjs#19559
@tongxuanbao tongxuanbao linked a pull request Apr 9, 2024 that will close this issue
Open
@tongxuanbao
Copy link
Author

tongxuanbao commented Apr 9, 2024 •
edited

I added a quick PR for maintainers to have a look, essentially focus event fired an extra time.

It has to something to do with the line in #19572. It worked as expected after removing it

@XStarlink
Copy link

I have the same problem,

I use v-text-field, and the autocomplete for the new-password only works from time to time.

@meganspaulding
Copy link

We are also seeing issues with VTextField on password fields calling focus() too many times, specifically on Chrome mobile we are seeing a maximum call exceeded error from some sort of focus() recalling. We are not manually calling focus()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(VTextField): new-password of autocomplete doesn't behave correctly on chrome tongxuanbao/vuetify
4 participants
@tongxuanbao @KaelWD @XStarlink @meganspaulding