Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTextField): new-password of autocomplete doesn't behave correctly on chrome #19572

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tongxuanbao
Copy link

Description

fixes #19559

Markup:

<template>
  <v-app>
    <v-container>
      <v-responsive
        class="mx-auto"
        width="344"
      >
        <v-form>
          <v-label>Vuetify field</v-label>
          <v-text-field
            autocomplete="new-password"
            label="Password"
            name="password"
            type="password"
          />
          <v-text-field
            autocomplete="new-password"
            label="Confirm Password"
            name="confirm password"
            type="password"
          />
        </v-form>
        <!-- <form class="pure-form">
          <fieldset>
            <legend>Confirm password with HTML5</legend>

            <input id="password" placeholder="Password" type="password" required>
            <input id="confirm_password" placeholder="Confirm Password" type="password" required>

            <button class="mx-1" type="submit">Confirm</button>
          </fieldset>
        </form> -->
      </v-responsive>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    name: 'Playground',
    setup () {
      return {
        //
      }
    },
  }
</script>

@johnleider
Copy link
Member

This seems like it would cause issues, why was the code you're removing put there in the first place?

@tongxuanbao
Copy link
Author

Ah i see, the code is being used to focus on the TextField when we click or clear. Let me know if reverting the focus event to the before of this PR #14504 - feat(VSelect): port to v3 makes any sense.

What we're trying to do is to streamline our sign up page, and making password suggestion works better helps with that.

@johnleider
Copy link
Member

johnleider commented Apr 11, 2024

Is there a different way that we can approach it without causing a regression?

@johnleider johnleider added the S: stale This issue is untriaged and hasn't seen any activity in at least six months. label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTextField VTextField S: stale This issue is untriaged and hasn't seen any activity in at least six months. T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.5.14] autocomplete="new-password" doesn't work well with chrome autofill when editing
3 participants