-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request][v-dialog] fullscreen reactivity #2201
Comments
I'm a bit confused by this request. Are you asking for the |
No, by reactivity I mean the possibility to resize the window while the dialog is open (for ex. from landscape) Now the state is taken before the dialog is open, now while its open. Mostly for the backdrop now. When you open the dialog in fullscreen and then the viewport changes to classic dialog the backdrop is missing and vice versa. Most usages of this are on portable devices like tablets. Hope I answered your question. |
@CodeSkills Can you find the codepen you posted in discord and put it in the issue? EDIT: updated codepen as of 1.0.10: https://codepen.io/anon/pen/ZxXQrp?editors=1010 |
It was this one https://codepen.io/anon/pen/yzRdMJ But it was to show the problem with backdrop not disappearing after fullscreen dialog close, which was already fixed. But the backdrop is not reactive, which you can see there also. |
Shouldn't this be treated as a bug? I was just going to open a new issue when I found this one and I believe it describes the same problem. Code: When you open a dialog on XS it is in full screen mode as expected. But now if you resize to something bigger and toggle |
Yeah probably |
It's not only a visual problem (no backdrop). Everything in the "background" will react to events now. |
This is being moved to v1.4 as it is directly tied to #5015 |
This comment has been minimized.
This comment has been minimized.
Hey guys, |
@bartmichu Have you solved this bug |
Now it works as expected in my case, #5707 fixed it for me.
|
@bartmichu @johnleider |
Feature Request
When applying fullscreen for v-dialog based on the docs so it could be reactive.
<v-dialog :fullscreen="$vuetify.breakpoint.xsOnly"> ... </v-dialog>
Knows issues
The text was updated successfully, but these errors were encountered: