Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request][v-dialog] fullscreen reactivity #2201

Closed
CodeSkills opened this issue Oct 16, 2017 · 13 comments · Fixed by #5707
Closed

[Feature Request][v-dialog] fullscreen reactivity #2201

CodeSkills opened this issue Oct 16, 2017 · 13 comments · Fixed by #5707
Assignees
Labels
T: bug Functionality that does not work as intended/expected
Milestone

Comments

@CodeSkills
Copy link

CodeSkills commented Oct 16, 2017

Feature Request

When applying fullscreen for v-dialog based on the docs so it could be reactive.
<v-dialog :fullscreen="$vuetify.breakpoint.xsOnly"> ... </v-dialog>

Knows issues

  • Overlay needs to be shown only if the fullscreen is true, otherwise it could be destroyed and again generated only when resize happens with fullscreen false.
  • Scrollbar is hidden when fullscreen, even if the dialog is not visible yet ([Bug Report] Y overflow is hidden on mobile #5566).
@johnleider johnleider added the pending review The issue is still pending disposition label Oct 21, 2017
@johnleider
Copy link
Member

I'm a bit confused by this request. Are you asking for the v-dialog component to automatically use the breakpoint object to change its state?

@johnleider johnleider removed the pending review The issue is still pending disposition label Oct 21, 2017
@CodeSkills
Copy link
Author

No, by reactivity I mean the possibility to resize the window while the dialog is open (for ex. from landscape)

Now the state is taken before the dialog is open, now while its open. Mostly for the backdrop now. When you open the dialog in fullscreen and then the viewport changes to classic dialog the backdrop is missing and vice versa.

Most usages of this are on portable devices like tablets.

Hope I answered your question.

@KaelWD
Copy link
Member

KaelWD commented Oct 21, 2017

@CodeSkills Can you find the codepen you posted in discord and put it in the issue?

EDIT: updated codepen as of 1.0.10: https://codepen.io/anon/pen/ZxXQrp?editors=1010

@CodeSkills
Copy link
Author

It was this one

https://codepen.io/anon/pen/yzRdMJ

But it was to show the problem with backdrop not disappearing after fullscreen dialog close, which was already fixed. But the backdrop is not reactive, which you can see there also.

@johnleider johnleider added this to the v1.2.x milestone Jan 7, 2018
@johnleider johnleider added T: feature A new feature and removed need more info labels Jan 7, 2018
@KaelWD KaelWD added T: enhancement Functionality that enhances existing features and removed T: feature A new feature labels Mar 25, 2018
@bartmichu
Copy link

Shouldn't this be treated as a bug? I was just going to open a new issue when I found this one and I believe it describes the same problem.

Code:
<v-dialog value="true" :fullscreen="$vuetify.breakpoint.xs" persistent max-width="90%">

When you open a dialog on XS it is in full screen mode as expected. But now if you resize to something bigger and toggle fullscreen programmatically there is no shade in the background - and that's a bug.

@KaelWD
Copy link
Member

KaelWD commented Jul 2, 2018

Yeah probably

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected and removed T: enhancement Functionality that enhances existing features labels Jul 2, 2018
@bartmichu
Copy link

bartmichu commented Jul 28, 2018

It's not only a visual problem (no backdrop). Everything in the "background" will react to events now.

@KaelWD KaelWD modified the milestones: v1.2.0, v1.3.0 Jul 29, 2018
@johnleider
Copy link
Member

This is being moved to v1.4 as it is directly tied to #5015

@TheInvoker

This comment has been minimized.

@narkissbv
Copy link

Hey guys,
What's the status here? I've just tried reactively change the state of fullscreen like so: :fullscreen="$vuetify.breakpoint.mdAndDown" and it seems to not work.
Using Vuetify v1.4.4.

@YaoHuangMark
Copy link

It's not only a visual problem (no backdrop). Everything in the "background" will react to events now.

@bartmichu Have you solved this bug

@bartmichu
Copy link

bartmichu commented May 13, 2019 via email

@YaoHuangMark
Copy link

@bartmichu @johnleider
I actually want to ask, a full-screen dialog, when I type something into the text-field on my phone, I can see and swipe the background content, I can see all the background content。
If you know,please tell me

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants