Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Tooltip on focusable elements does not close automatically when changing route #2480

Closed
raymadrona opened this issue Nov 12, 2017 · 4 comments · Fixed by #2780
Closed
Labels
T: bug Functionality that does not work as intended/expected
Milestone

Comments

@raymadrona
Copy link

Versions and Environment

Vuetify: 0.16.9
Vue: 2.4.3
Browsers: Chrome 62.0.3202.75
OS: Windows 10

Steps to reproduce

Using vue-router, having the router-view wrap with keep-alive.
Changing of route using elements such as buttons or <a> tags causes this behavior. The tooltip still appear even the activator is now hidden.

Check the reproduction link to see it in action.

Expected Behavior

The tooltip must be hidden after changing route.

Actual Behavior

The tooltip still visible after changing route.

Reproduction Link

https://jsfiddle.net/ott3jgah/4/

Other comments

I recommend also to have a functionality of showing tooltip when a focusable elements such buttons, inputs and <a> tags has focus. This feature/functionality will automatically fix this bug.

We can add this code on the tooltip component:

focusin: () => {
    this.runDelay('close', () => (this.isActive = true))
},
focusout: () => {
    this.runDelay('close', () => (this.isActive = false))
}
@johnleider johnleider added the pending review The issue is still pending disposition label Nov 15, 2017
@nekosaur nekosaur added T: bug Functionality that does not work as intended/expected and removed pending review The issue is still pending disposition labels Nov 15, 2017
@KaelWD
Copy link
Member

KaelWD commented Nov 16, 2017

This can probably be done by hiding the tooltip in the deactivated lifecycle method.

@Utwo
Copy link

Utwo commented Nov 23, 2017

Same on v-select

stormy251 pushed a commit to stormy251/vuetify that referenced this issue Dec 12, 2017
stormy251 pushed a commit to stormy251/vuetify that referenced this issue Dec 12, 2017
…le it was a child of the keep-alive component

fixes vuetifyjs#2480
KaelWD pushed a commit to stormy251/vuetify that referenced this issue Dec 18, 2017
@KaelWD KaelWD added this to the v0.17.x milestone Dec 18, 2017
@raymadrona
Copy link
Author

The issue still occurs on mobile.

@johnleider
Copy link
Member

If you are still encountering issues, please create a new ticket: https://issues.vuetifyjs.com

@vuetifyjs vuetifyjs locked as resolved and limited conversation to collaborators Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants