feat(VMenu): disable-keys prop

[jacekkarczmarczyk]

Description

Adds disable-keys prop to disable the keyboard event handlers used only when the v-menu is used as a real menu with selecting items by pressing up/down/enter etc

Motivation and Context

fixes #5103

How Has This Been Tested?

visually, unit

Markup:

<template>
  <v-app>
    <v-content>
      <v-container>
        <v-menu attach :close-on-content-click="false" :close-on-click="false" disable-keys>
          <v-btn slot="activator">Open</v-btn>
          <v-card class="pa-3" width="800">
            <v-text-field label="Focus me and press TAB"></v-text-field>
            <v-text-field></v-text-field>
          </v-card>
        </v-menu>
      </v-container>
    </v-content>
  </v-app>
</template>

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

• The PR title is no longer than 64 characters.
• The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have created a PR in the documentation with the necessary changes.

[johnleider]

I know that we have older exceptions else where, but I tend to lean towards props that require boolean true to be active as opposed to writing :prop="false". Thoughts?

[jacekkarczmarczyk]

i'm ok with disableKeys prop (default: false)

[johnleider]

This is tagged as a bug but submitted to the dev branch, could you provide additional insight?

[jacekkarczmarczyk]

It introduces a new disable-keys prop

[KaelWD]

Alternative without a new prop: #5716

[codecov]

Codecov Report

Merging #5138 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #5138      +/-   ##
==========================================
+ Coverage   88.52%   88.54%   +0.01%     
==========================================
  Files         281      281              
  Lines        6303     6303              
  Branches     1581     1581              
==========================================
+ Hits         5580     5581       +1     
+ Misses        605      604       -1     
  Partials      118      118

Impacted Files	Coverage Δ
...uetify/src/components/VMenu/mixins/menu-keyable.js	95.45% <ø> (+4.54%)	⬆️
packages/vuetify/src/components/VMenu/VMenu.js	83.63% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4906f03...d8a587d. Read the comment docs.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord