Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v-select menu prop "auto" not centering on selected item when dense prop is added #5149

Closed
emcho92 opened this issue Sep 22, 2018 · 1 comment · Fixed by #5448
Closed

v-select menu prop "auto" not centering on selected item when dense prop is added #5149

emcho92 opened this issue Sep 22, 2018 · 1 comment · Fixed by #5448
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@emcho92
Copy link

emcho92 commented Sep 22, 2018

Versions and Environment

Vuetify: 1.2.4
Vue: 2.5.17
Browsers: 69.0.3497.100
OS: macOS 10.13.6

Steps to reproduce

Add the dense prop to a v-select with an "auto" menu-prop.

Expected Behavior

The select should be scrolling to the selected item when the menu opens so that the selected item is in the center of the menu.

Actual Behavior

The select does scroll but the selected item is not in the center, rather on the top, even cut off a bit.

Reproduction Link

Here is the example from the docs where I just added the dense prop to the first select, while the one below has not been modified, see the difference.


I think it's related to the height, since the dense prop makes the menu list items smaller, so the scrolling that centers the selected item needs to account for that.

@emcho92
Copy link
Author

emcho92 commented Oct 3, 2018

Can we get a status or tag on this?

@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Oct 25, 2018
@johnleider johnleider added S: has PR The issue has a pending Pull Request and removed S: work in progress labels Oct 26, 2018
jacekkarczmarczyk added a commit that referenced this issue Nov 1, 2018
jacekkarczmarczyk added a commit that referenced this issue Nov 10, 2018
KaelWD pushed a commit that referenced this issue Nov 23, 2018
jacekkarczmarczyk added a commit that referenced this issue Nov 23, 2018
* fix(VMenu): calculate auto position

fixes #5149

* more fixes

* updated function name

* fix: position for autocompletes

* removed ununsed data

* fix: turn off unnecessary transitions

* properly remove unnecessary transition

* fix: add back staggered list transition
@lock lock bot locked as resolved and limited conversation to collaborators Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants