Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] onChange for timePicker #5266

Closed
pwildschut opened this issue Oct 11, 2018 · 4 comments
Closed

[Bug Report] onChange for timePicker #5266

pwildschut opened this issue Oct 11, 2018 · 4 comments
Assignees
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@pwildschut
Copy link

What problem does this feature solve?

In the case that a variable change is a trigger for other functionality the onInput event generates too much noise. An onChange event would be more reliable

What is your proposed solution?

I have seen in the code that the timePicker is prepared to return the onchange event. it just seems to be returning the input value, so its actually not doing anything :/

@johnleider johnleider added the pending review The issue is still pending disposition label Oct 11, 2018
@jacekkarczmarczyk
Copy link
Member

@pwildschut Can you provide a codepen with explanation what and when should happen?

@pwildschut
Copy link
Author

I have created this to visualize, somehow it looks weird. But functionally it proves my point.

https://codepen.io/pwildschut/pen/aRVJaN

Apologies for the delayed answer.

@KaelWD
Copy link
Member

KaelWD commented Oct 16, 2018

It always emits 00:25 for me, I'd call this a bug.

@jacekkarczmarczyk
Copy link
Member

It works better if you use v-model, but maybe this behaviour could be fixed too

@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected S: has PR The issue has a pending Pull Request and removed pending review The issue is still pending disposition labels Nov 21, 2018
@MajesticPotatoe MajesticPotatoe changed the title onChange for timePicker [Bug Report] onChange for timePicker Dec 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

4 participants