Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] v-checkbox with tabindex creates two tabstops #5412

Closed
grant007 opened this issue Oct 24, 2018 · 2 comments
Closed

[Bug Report] v-checkbox with tabindex creates two tabstops #5412

grant007 opened this issue Oct 24, 2018 · 2 comments
Assignees
@nekosaur
Labels
C: VCheckbox VCheckbox T: bug Functionality that does not work as intended/expected
Milestone
v2.0.0

Comments

@grant007
Copy link

Versions and Environment

Vuetify: 1.3.1
Vue: 2.5.16
Browsers: Chrome, Safari
OS: OSX

Previously worked in:

Vuetify:
Vue:

Steps to reproduce

Create a v-checkbox like...
<v-checkbox v-model="x" :tabindex="1"></v-checkbox>

Expected Behavior

Single tabindex="1" attribute on the resultant input element.

Actual Behavior

Two tabindex="1" attributes, one on a parent div and one on the input element.

Reproduction Link

https://codepen.io/grant007/pen/LgXYew

Additional Comments:
@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Oct 24, 2018
@KaelWD
Copy link
Member

KaelWD commented Oct 24, 2018

Worked in 1.0, broken since 1.1

@MajesticPotatoe MajesticPotatoe changed the title v-checkbox with tabindex creates two tabstops [Bug Report] v-checkbox with tabindex creates two tabstops Dec 7, 2018
@scippio
Copy link

scippio commented Mar 17, 2019 •
edited
Loading

  • and v-switch has this bug too...

@MajesticPotatoe MajesticPotatoe added the C: VCheckbox VCheckbox label Apr 10, 2019
@nekosaur nekosaur self-assigned this Jun 19, 2019
nekosaur added a commit that referenced this issue Jun 19, 2019
@nekosaur
fix(VInput): attrs should be applied on input not root element
8718882 
this fixes issue where setting for example tabindex on checkbox
results in it being applied both in input element and on root div

closes #5412
@nekosaur nekosaur mentioned this issue Jun 19, 2019
Merged
8 tasks
nekosaur added a commit that referenced this issue Jun 21, 2019
@nekosaur
fix(VInput): attrs should be applied on input not root element (#7579)
318553a 
this fixes issue where setting for example tabindex on checkbox
results in it being applied both in input element and on root div

closes #5412
@johnleider johnleider added this to the v2.0.0 milestone Jun 26, 2019
This was referenced Jul 23, 2019
Merged
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Merged
Closed
This was referenced Jul 23, 2019
Closed
Merged
Closed
Merged
Closed
Closed
This was referenced Sep 20, 2019
Closed
Merged
Closed
@renovate renovate bot mentioned this issue Aug 23, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nekosaur nekosaur

Labels
C: VCheckbox VCheckbox T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
7 participants
@nekosaur @scippio @grant007 @johnleider @jacekkarczmarczyk @KaelWD @MajesticPotatoe