Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Duplicate names in breadcrumbs array lead to error #5454

Closed
ndabAP opened this issue Oct 27, 2018 · 3 comments · Fixed by #6642
Closed

[Bug Report] Duplicate names in breadcrumbs array lead to error #5454

ndabAP opened this issue Oct 27, 2018 · 3 comments · Fixed by #6642
Labels
T: bug Functionality that does not work as intended/expected
Milestone
v2.0.0

Comments

@ndabAP
Copy link

ndabAP commented Oct 27, 2018 •
edited

Versions and Environment

Vuetify: 1.3.3
Vue: 2.5.17
Browsers: Chrome 69.0.3497.100
OS: Linux x86_64

Steps to reproduce

  1. Visit link
  2. open console and see error

Expected Behavior

Breadcrumbs with duplicate names should be possible.

Actual Behavior

Error.

Reproduction Link

https://codepen.io/anon/pen/NOJqqM?editors=1010
@onx2
Copy link

onx2 commented Oct 30, 2018

What is your use case for the same name being repeated? I would assume each breadcrumb link to be unique since it is a listing of the previous / parent pages.

@ndabAP
Copy link
Author

ndabAP commented Oct 30, 2018 •
edited

My customers can create names for the entities and the entities are nested. Example: User has a table named "Test" and inside that table a dashboard named "Test".

Tables > Test > Dashboards > Test

"Tables" and "Dashboards" are defined by application and "Test" defined by user.

@onx2
Copy link

onx2 commented Oct 30, 2018

Got it -- that makes sense.

I'm not very familiar with the breadcrumb code, but maybe in VBreadcrumbs.ts the genItems function could be refactored to use a different key than the item.text?

@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Nov 1, 2018
@johnleider johnleider added this to the v2.0.0 milestone Nov 1, 2018
nekosaur added a commit that referenced this issue Feb 28, 2019
@nekosaur
fix(VBreadcrumbs): v-for key error when two items have identical texts
70ff820 
closes #5454
@nekosaur nekosaur mentioned this issue Feb 28, 2019
Merged
8 tasks
johnleider pushed a commit that referenced this issue Mar 3, 2019
@nekosaur @johnleider
fix(VBreadcrumbs): v-for key error when two items have identical texts (
2146ca8 
#6642)

* fix(VBreadcrumbs): v-for key error when two items have identical texts

closes #5454

* test(VBreadcrumbs): remove .only from test
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

fix(VBreadcrumbs): v-for key error when two items have identical texts vuetifyjs/vuetify
3 participants
@ndabAP @johnleider @onx2