-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VAutocomplete): Update dynamically when itemText is updated #6431
fix(VAutocomplete): Update dynamically when itemText is updated #6431
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6431 +/- ##
==========================================
+ Coverage 84.56% 84.59% +0.03%
==========================================
Files 297 297
Lines 7120 7121 +1
Branches 1764 1764
==========================================
+ Hits 6021 6024 +3
+ Misses 1014 1013 -1
+ Partials 85 84 -1
Continue to review full report at Codecov.
|
Can you also add unit tests for this? |
@jacekkarczmarczyk Yes, I will go ahead and do that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests for this, otherwise LGTM
…x/item-text-dyn-update
I updated the PR and added in the necessary unit tests. |
Closes #6368
Description
Motivation and Context
Addresses #6368
How Has This Been Tested?
visually
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).