Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] VSlider value can be set to be less than the min value and renders incorrectly #6604

Closed
hrayr-artunyan opened this issue Feb 25, 2019 · 0 comments · Fixed by #6605
Closed

[Bug Report] VSlider value can be set to be less than the min value and renders incorrectly #6604

hrayr-artunyan opened this issue Feb 25, 2019 · 0 comments · Fixed by #6605
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@hrayr-artunyan
Copy link
Contributor

Versions and Environment

Vuetify: 1.5.2
Vue: 2.6.7
Browsers: Chrome 73.0.3683.46
OS: Mac OS 10.14.2

Steps to reproduce

Create a VSlider with min and max values and set the value of the slider to be less than the min value.

Expected Behavior

The value should be set to the min value.

Actual Behavior

The value is not set to the min value, and the thumb is positioned outside of the slider.

Reproduction Link

https://codepen.io/hrayr/pen/MxWvYR
hrayr-artunyan added a commit to hrayr-artunyan/vuetify that referenced this issue Feb 25, 2019
@hrayr-artunyan
fix(VSlider): set value to min if it's less than min (vuetifyjs#6604)
d6d0877 
fixes vuetifyjs#6604
@hrayr-artunyan hrayr-artunyan mentioned this issue Feb 25, 2019
Merged
8 tasks
@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected S: has PR The issue has a pending Pull Request labels Mar 1, 2019
hrayr-artunyan added a commit to hrayr-artunyan/vuetify that referenced this issue Mar 2, 2019
@hrayr-artunyan
fix(VSlider): set value to min if it's less than min (vuetifyjs#6604)
4a27bd8 
fixes vuetifyjs#6604
hrayr-artunyan added a commit to hrayr-artunyan/vuetify that referenced this issue Mar 2, 2019
@hrayr-artunyan
test(VSlider): Check roundValue is bounded by min and max
6e0a64f 
The roundValue function gets used by inputWidth to determine placement of the thumb and various
other elements. If the initial value is less than min, inputWidth will return a negative number due
to the roundValue not being bounded by min and max. This test will check the boundaries.

test for fix vuetifyjs#6604
johnleider pushed a commit that referenced this issue Mar 3, 2019
@hrayr-artunyan @johnleider
fix(VSlider): set value to min if it's less than min (#6604) (#6605)
91eb0db 
* fix(VSlider): set value to min if it's less than min (#6604)

fixes #6604

* test(VSlider): Check roundValue is bounded by min and max

The roundValue function gets used by inputWidth to determine placement of the thumb and various
other elements. If the initial value is less than min, inputWidth will return a negative number due
to the roundValue not being bounded by min and max. This test will check the boundaries.

test for fix #6604
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(VSlider): set value to min if it's less than min (#6604) hrayr-artunyan/vuetify
2 participants
@hrayr-artunyan @jacekkarczmarczyk