-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VSlider): set value to min if it's less than min (#6604) #6605
fix(VSlider): set value to min if it's less than min (#6604) #6605
Conversation
Thank you for your contribution. Could you possibly create a test for this as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please add unit test for this.
Codecov Report
@@ Coverage Diff @@
## master #6605 +/- ##
=======================================
Coverage 85.69% 85.69%
=======================================
Files 298 298
Lines 7173 7173
Branches 1784 1784
=======================================
Hits 6147 6147
Misses 935 935
Partials 91 91
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #6605 +/- ##
=======================================
Coverage 85.68% 85.68%
=======================================
Files 298 298
Lines 7175 7175
Branches 1785 1785
=======================================
Hits 6148 6148
Misses 936 936
Partials 91 91
Continue to review full report at Codecov.
|
@hrayr-artunyan please add unit tests! |
@sh7dm I will do so shortly. Thank you. |
The roundValue function gets used by inputWidth to determine placement of the thumb and various other elements. If the initial value is less than min, inputWidth will return a negative number due to the roundValue not being bounded by min and max. This test will check the boundaries. test for fix vuetifyjs#6604
fbe6e21
to
6e0a64f
Compare
Description
Forces the slider value to be within the boundaries set by min and max props.
Motivation and Context
fixes #6604
How Has This Been Tested?
Tested visually with the provided playground code.
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).