Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VCarousel): v2 update #6924

Merged
merged 26 commits into from
Apr 6, 2019
Merged

feat(VCarousel): v2 update #6924

merged 26 commits into from
Apr 6, 2019

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Apr 4, 2019

Description

Added new features:

  • move arrow logic to v-window so that implementing components can get access to prev/next (v-tabs, v-stepper)
  • added continuous prop to v-window (in conjunction with the arrows)
    • can only progress through the carousel linearly
  • added show-arrows-on-hover prop
  • added soft outline for arrows (helps with ligher background pictures) to v-window
  • added hide-delimiter-background that removes background from delimiter icons
  • added vertical-delimiters prop
  • BREAKING: the cycle prop is no longer implicit

fixes #5260
fixes #5363
fixes #6067
resolves #6158
resolves #6261

Motivation and Context

Improve the look and feel of a very old component

How Has This Been Tested?

jest / visually

Markup:

Kitchen/Docs

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added the T: enhancement Functionality that enhances existing features label Apr 4, 2019
@johnleider johnleider added this to the v2.0.0 milestone Apr 4, 2019
@johnleider johnleider self-assigned this Apr 4, 2019
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #6924 into next will increase coverage by 0.09%.
The diff coverage is 77.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6924      +/-   ##
==========================================
+ Coverage   82.59%   82.69%   +0.09%     
==========================================
  Files         329      329              
  Lines        8408     8421      +13     
  Branches     2135     2136       +1     
==========================================
+ Hits         6945     6964      +19     
+ Misses       1368     1362       -6     
  Partials       95       95
Impacted Files Coverage Δ
...ages/vuetify/src/components/VCarousel/VCarousel.ts 86.04% <66.66%> (+11.44%) ⬆️
packages/vuetify/src/components/VWindow/VWindow.ts 91.78% <78.57%> (-8.22%) ⬇️
...kages/vuetify/src/components/VRadioGroup/VRadio.ts
.../vuetify/src/components/VRadioGroup/VRadioGroup.ts
...ckages/vuetify/src/components/VRadioGroup/index.ts
...ckages/vuetify/src/components/VRadioGroup/index.js 100% <0%> (ø)
...kages/vuetify/src/components/VRadioGroup/VRadio.js 100% <0%> (ø)
.../vuetify/src/components/VRadioGroup/VRadioGroup.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1949cb...865cde5. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #6924 into next will increase coverage by 0.21%.
The diff coverage is 96.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6924      +/-   ##
==========================================
+ Coverage   84.35%   84.56%   +0.21%     
==========================================
  Files         327      327              
  Lines        8392     8416      +24     
  Branches     2134     2145      +11     
==========================================
+ Hits         7079     7117      +38     
+ Misses       1217     1203      -14     
  Partials       96       96
Impacted Files Coverage Δ
...ages/vuetify/src/components/VCarousel/VCarousel.ts 100% <100%> (+25.39%) ⬆️
...ages/vuetify/src/components/VWindow/VWindowItem.ts 100% <100%> (ø) ⬆️
.../vuetify/src/components/VCarousel/VCarouselItem.ts 100% <100%> (ø) ⬆️
packages/vuetify/src/components/VWindow/VWindow.ts 97.36% <94.11%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc074c...b6ce119. Read the comment docs.

@vercel vercel bot temporarily deployed to staging April 4, 2019 23:27 Inactive
@vercel vercel bot temporarily deployed to staging April 5, 2019 01:06 Inactive
@vercel vercel bot temporarily deployed to staging April 5, 2019 21:11 Inactive
@johnleider johnleider merged commit 5c06f4d into next Apr 6, 2019
@johnleider johnleider deleted the feat/md2-carousel branch April 6, 2019 19:12
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: enhancement Functionality that enhances existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants