Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Using Carousel Items as Links #6261

Closed
Talha-T opened this issue Jan 25, 2019 · 2 comments
Closed

[Feature Request] Using Carousel Items as Links #6261

Talha-T opened this issue Jan 25, 2019 · 2 comments
Assignees
@johnleider
Labels
T: enhancement Functionality that enhances existing features T: feature A new feature
Milestone
v2.0.0

Comments

@Talha-T
Copy link

Talha-T commented Jan 25, 2019 •
edited

Problem to solve

Being able to navigate to a desired page on carousel item click. According to this github issue , it should be already added; but it doesn't work currently.

Codepen: https://codepen.io/anon/pen/PVZPGJ

Proposed solution

Carousel Items should support "to" property for nuxt, so I should be able to navigate to a desired page when a carousel item is clicked.
@jacekkarczmarczyk
Copy link
Member

Can you please provide the codepen reproduction?

@Talha-T
Copy link
Author

Talha-T commented Jan 25, 2019

I have updated the issue.

@dsseng dsseng added T: enhancement Functionality that enhances existing features T: feature A new feature labels Jan 27, 2019
@johnleider johnleider self-assigned this Apr 5, 2019
@johnleider johnleider added this to the v2.0.0 milestone Apr 5, 2019
johnleider added a commit that referenced this issue Apr 5, 2019
@johnleider
feat(VCarouselItem): add **routable** support
0a53959 
resolves #6261
@johnleider johnleider mentioned this issue Apr 5, 2019
Merged
8 tasks
johnleider added a commit that referenced this issue Apr 6, 2019
@johnleider
feat(VCarousel): v2 update (#6924)
5c06f4d 
* refactor(VWindow/VCarousel): abstract arrow functionality plus more

added new **show-arrows-on-hover** prop and outlined controls

* refactor(VCarousel): change **cycle** prop default

must now explicitly declare cycle

BREAKING CHANGE: The **cycle** prop is no longer implicit, must be defined in order to have screens
switch

* refactor(VCarousel/VWindow): clean-up styles

* fix(VWindow): update default for **show-arrows** prop

* docs(VCarousel): add new **cycle** example

* docs(VCarousel): update example

* docs(VCarousel): update **customTransition** example

* refactor(VCarousel): remove duplicated (essentially) render function

* refactor(VWindow): abstract **show-arrows-on-hover** from `v-carousel`

* feat(VCarousel): add **progress** prop

* refactor(VWindow): reduce control margin

* refactor(VWindow): reduce size of controls

* refactor(VCarousel): **progres-color** is inferred as default from `v-progress-linear`

* feat(VCarousel): add **vertical-delmiiters** prop

resolves #6158

* fix(VCarousel): pass through parent height to children item

fixes #6067

* test(VCarousel): expand coverage

* test(VWindows): expand coverage for new functionality

* feat(VCarouselItem): add **routable** support

resolves #6261

* fix(VWindow): use proper transition when in rtl mode

resolves #6696

* test(VWindow): expand coverage

* refactor(VWindow): increase control icon size

* style(VWindow): improve code style

* docs(VCarousel): improve documentation
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johnleider johnleider

Labels
T: enhancement Functionality that enhances existing features T: feature A new feature
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
4 participants
@johnleider @jacekkarczmarczyk @dsseng @Talha-T