Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(VParallax): update for v2 #7042

Merged
merged 1 commit into from
Apr 23, 2019
Merged

refactor(VParallax): update for v2 #7042

merged 1 commit into from
Apr 23, 2019

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Apr 22, 2019

relied on translate to be called in order to boot, this doesn't occur when image is the same size as
the container

fixes #7010

Description

Motivation and Context

How Has This Been Tested?

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

relied on translate to be called in order to boot, this doesn't occur when image is the same size as
the container

fixes #7010
@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #7042 into next will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next   #7042      +/-   ##
=========================================
+ Coverage   79.87%   79.9%   +0.02%     
=========================================
  Files         328     328              
  Lines        8383    8384       +1     
  Branches     2134    2134              
=========================================
+ Hits         6696    6699       +3     
+ Misses       1600    1599       -1     
+ Partials       87      86       -1
Impacted Files Coverage Δ
...ages/vuetify/src/components/VParallax/VParallax.ts 79.16% <100%> (+9.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d92edd...4182336. Read the comment docs.

@johnleider johnleider self-assigned this Apr 23, 2019
@johnleider johnleider added this to the v2.0.0 milestone Apr 23, 2019
@johnleider johnleider added the T: enhancement Functionality that enhances existing features label Apr 23, 2019
@johnleider johnleider merged commit c6f3a2c into next Apr 23, 2019
@johnleider johnleider deleted the refactor/v2-parallax branch April 23, 2019 20:11
@lock lock bot locked as resolved and limited conversation to collaborators May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: enhancement Functionality that enhances existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants