Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] v-parallax not shown if height is the same as the image height #7010

Closed
andrewspy opened this issue Apr 17, 2019 · 1 comment
Closed

[Bug Report] v-parallax not shown if height is the same as the image height #7010

andrewspy opened this issue Apr 17, 2019 · 1 comment
Assignees
@johnleider
Labels
C: VParallax VParallax T: bug Functionality that does not work as intended/expected
Milestone
v2.0.0

Comments

@andrewspy
Copy link

Versions and Environment

Vuetify: 1.5.12
Vue: 2.6.8
Browsers: Chrome 73.0.3683.103
OS: Windows 10

Steps to reproduce

See https://codepen.io/anon/pen/axEXMm

Expected Behavior

Image is shown

Actual Behavior

Image is not shown

Reproduction Link

https://codepen.io/anon/pen/axEXMm

Other comments

It will work as long as the height of parallax is not the same as the height of the image
@ghost ghost added the S: triage label Apr 17, 2019
@ibrahimBeladi
Copy link
Contributor

After debugging this, what I realized is that when the heights are the same the img tag (with class "v-parallax__image") have a style rule of "opacity: 0;", otherwise it would be "opacity: 1;"

@johnleider johnleider added C: VParallax VParallax T: bug Functionality that does not work as intended/expected and removed S: triage labels Apr 22, 2019
@johnleider johnleider added this to the v2.0.0 milestone Apr 22, 2019
@johnleider johnleider self-assigned this Apr 22, 2019
johnleider added a commit that referenced this issue Apr 22, 2019
@johnleider
fix(VParallax): show image if no translation is available
4182336 
relied on translate to be called in order to boot, this doesn't occur when image is the same size as
the container

fixes #7010
@johnleider johnleider mentioned this issue Apr 22, 2019
Merged
8 tasks
johnleider added a commit that referenced this issue Apr 23, 2019
@johnleider
fix(VParallax): show image if no translation is available (#7042)
c6f3a2c 
relied on translate to be called in order to boot, this doesn't occur when image is the same size as
the container

fixes #7010
This was referenced Jul 23, 2019
Merged
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Merged
Closed
This was referenced Jul 23, 2019
Closed
Merged
Closed
Merged
Closed
Closed
This was referenced Sep 20, 2019
Closed
Merged
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johnleider johnleider

Labels
C: VParallax VParallax T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
3 participants
@andrewspy @johnleider @ibrahimBeladi