Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] (VToolbar) wrapping an v-btn in an extra div messes up the styling #7400

Closed
DRoet opened this issue Jun 5, 2019 · 1 comment
Closed

[Bug Report] (VToolbar) wrapping an v-btn in an extra div messes up the styling #7400

DRoet opened this issue Jun 5, 2019 · 1 comment
Assignees
@johnleider
Labels
C: VToolbar VToolbar T: bug Functionality that does not work as intended/expected
Milestone
v2.0.0

Comments

@DRoet
Copy link
Contributor

DRoet commented Jun 5, 2019

Versions and Environment

Vuetify: 2.0.0-beta.1
Last working version: 1.5.14
Vue: 2.6.10
Browsers: Chrome 74.0.3729.169
OS: Windows 10

Steps to reproduce

Wrap a v-btn in an additional div within a v-toolbar

Expected Behavior

v-btn displays with the correct styling

Actual Behavior

v-btn displays as a smaller btn and there is no way of manually fixing it through a prop, since <v-btn large> causes the ripple/btn to be too big

Reproduction Link

https://codepen.io/anon/pen/RmvOOj?&editable=true&editors=101

Comments

This is especially usefull when you are splitting your buttons into seperate components
@DRoet DRoet added T: bug Functionality that does not work as intended/expected C: VToolbar VToolbar labels Jun 5, 2019
@ghost ghost added the S: triage label Jun 5, 2019
@jacekkarczmarczyk
Copy link
Member

image

@johnleider johnleider self-assigned this Jun 14, 2019
@johnleider johnleider added this to the v2.0.0 milestone Jun 14, 2019
johnleider added a commit that referenced this issue Jun 14, 2019
@johnleider
fix(VToolbar): always apply increased size to v-btn with the icon prop
3a1fc40 
also provided information on documentation when using wrappers around btns

fixes #7400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
C: VToolbar VToolbar T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
3 participants
@DRoet @johnleider @jacekkarczmarczyk