Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Unable to change button colors and sizes in VBtnToggle #7420

Closed
Mintonne opened this issue Jun 6, 2019 · 1 comment
Closed

[Bug Report] Unable to change button colors and sizes in VBtnToggle #7420

Mintonne opened this issue Jun 6, 2019 · 1 comment
Assignees
@johnleider
Labels
C: VBtnToggle VBtnToggle S: has PR The issue has a pending Pull Request T: regression Something that used to work but we broke
Milestone
v2.0.0

Comments

@Mintonne
Copy link

Mintonne commented Jun 6, 2019

Versions and Environment

Vuetify: 2.0.0-beta.1
Last working version: 1.5.14
Vue: 2.6.10
Browsers: Google Chrome, Mozilla Firefox
OS: Windows 10

Steps to reproduce

Create VBtnToggle in 2.0 & 1.5

Attempt to modify button color and sizes using VBtn props.

Expected Behavior

https://codepen.io/anon/pen/joRrGM

Actual Behavior

https://codepen.io/anon/pen/VONjmE

Reproduction Link

https://codepen.io/anon/pen/VONjmE
@ghost ghost added the S: triage label Jun 6, 2019
@KaelWD KaelWD added C: VBtnToggle VBtnToggle T: regression Something that used to work but we broke and removed S: triage labels Jun 7, 2019
@KaelWD
Copy link
Member

KaelWD commented Jun 7, 2019

Specificity too high on these rules
image

@johnleider johnleider self-assigned this Jun 14, 2019
johnleider added a commit that referenced this issue Jun 14, 2019
@johnleider
fix(VBtnToggle): restructure styles
e51f4b8 
allow manual override of btn color/size, improve state visual clarity

fixes #7420
@johnleider johnleider mentioned this issue Jun 14, 2019
Merged
8 tasks
@johnleider johnleider added the S: has PR The issue has a pending Pull Request label Jun 14, 2019
johnleider added a commit that referenced this issue Jun 16, 2019
@johnleider
fix(VBtnToggle): restructure styles, improve v-btn color override (#7515
4b4b1a1 
)

* fix(VBtnToggle): restructure styles

allow manual override of btn color/size, improve state visual clarity

fixes #7420

* refactor(VBtnToggle): add sass variables
@johnleider johnleider added this to the v2.0.0 milestone Jun 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johnleider johnleider

Labels
C: VBtnToggle VBtnToggle S: has PR The issue has a pending Pull Request T: regression Something that used to work but we broke
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
3 participants
@johnleider @KaelWD @Mintonne