Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add anchor color support #7455

Merged
merged 2 commits into from
Jun 16, 2019
Merged

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Jun 10, 2019

resolves #6360

Description

Added the ability to define an application's anchor color

Motivation and Context

Currently, the anchor color is defined as the application's primary color which may not always be desired

How Has This Been Tested?

jest

Markup:

// Paste your FULL Playground.vue here
// dev/index.js

const vuetify = new Vuetify({
  theme: {
    themes: {
      options: {
        // customProperties: true,
      },
      light: {
        anchor: '#000'
      }
    }
  },
  lang: {
    locales,
  },
})

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added the T: feature A new feature label Jun 10, 2019
@johnleider johnleider added this to the v2.0.0 milestone Jun 10, 2019
@johnleider johnleider self-assigned this Jun 10, 2019
@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #7455 into next will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7455      +/-   ##
==========================================
+ Coverage   87.17%   87.19%   +0.02%     
==========================================
  Files         326      326              
  Lines        8447     8453       +6     
  Branches     2116     2120       +4     
==========================================
+ Hits         7364     7371       +7     
+ Misses        993      992       -1     
  Partials       90       90
Impacted Files Coverage Δ
packages/vuetify/src/services/theme/utils.ts 100% <100%> (ø) ⬆️
packages/vuetify/src/components/VSelect/VSelect.ts 94.42% <0%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9bf9fe...fbe353a. Read the comment docs.

@johnleider johnleider requested review from a team June 10, 2019 19:49
@johnleider johnleider marked this pull request as ready for review June 10, 2019 19:49
@johnleider johnleider merged commit 40f3df8 into next Jun 16, 2019
@johnleider johnleider deleted the feat/add-anchor-color-support branch June 16, 2019 22:12
@lock lock bot locked as resolved and limited conversation to collaborators Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant