New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Configurable anchor color without CSS variables #6360

Open
simshaun opened this Issue Feb 4, 2019 · 0 comments

Comments

2 participants
@simshaun
Copy link

simshaun commented Feb 4, 2019

Problem to solve

Currently, anchor color CSS is generated by the theme javascript. If we choose to not use CSS variables (due to browser support), then anchors are given the primary base color.

Unfortunately for us, our base color doesn't work well for anchors. We can force anchors to be a certain color in our CSS (with !important), but it negatively impacts Vuetify components.

https://github.com/vuetifyjs/vuetify/blob/master/packages/vuetify/src/util/theme.ts#L90

Proposed solution

I'm not really sure of the drawbacks, but I was thinking it would be nice if there was a new key in the theme configuration hash/map for links. Maybe several keys: base/active/hover. If not declared, then fall back to the primary base color as it currently does.

@johnleider johnleider self-assigned this Feb 15, 2019

@johnleider johnleider added this to the v2.0.0 milestone Feb 15, 2019

@sh7dm sh7dm added this to 2.0 Tasks/To Do in Vuetify 2.0 Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment