Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Configurable anchor color without CSS variables #6360

Closed
simshaun opened this issue Feb 4, 2019 · 0 comments
Closed

[Feature Request] Configurable anchor color without CSS variables #6360

simshaun opened this issue Feb 4, 2019 · 0 comments
Assignees
@johnleider
Labels
S: has PR The issue has a pending Pull Request T: feature A new feature
Milestone
v2.0.0

Comments

@simshaun
Copy link

simshaun commented Feb 4, 2019

Problem to solve

Currently, anchor color CSS is generated by the theme javascript. If we choose to not use CSS variables (due to browser support), then anchors are given the primary base color.

Unfortunately for us, our base color doesn't work well for anchors. We can force anchors to be a certain color in our CSS (with !important), but it negatively impacts Vuetify components.

https://github.com/vuetifyjs/vuetify/blob/master/packages/vuetify/src/util/theme.ts#L90

Proposed solution

I'm not really sure of the drawbacks, but I was thinking it would be nice if there was a new key in the theme configuration hash/map for links. Maybe several keys: base/active/hover. If not declared, then fall back to the primary base color as it currently does.
@johnleider johnleider self-assigned this Feb 15, 2019
@johnleider johnleider added the T: feature A new feature label Feb 15, 2019
@johnleider johnleider added this to the v2.0.0 milestone Feb 15, 2019
johnleider added a commit that referenced this issue Jun 10, 2019
@johnleider
feat(theme): add the ability to define anchor color
04475ac 
resolves #6360
@johnleider johnleider mentioned this issue Jun 10, 2019
Merged
8 tasks
@johnleider johnleider added the S: has PR The issue has a pending Pull Request label Jun 11, 2019
johnleider added a commit that referenced this issue Jun 16, 2019
@johnleider
feat(theme): add anchor color support (#7455)
40f3df8 
* feat(theme): add the ability to define anchor color

resolves #6360

* docs(theme): add information for overriding anchor colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
S: has PR The issue has a pending Pull Request T: feature A new feature
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@simshaun @johnleider