Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] VSnackbar Content left padding differs from md2 spec #7772

Closed
185driver opened this issue Jul 7, 2019 · 1 comment
Closed

[Bug Report] VSnackbar Content left padding differs from md2 spec #7772

185driver opened this issue Jul 7, 2019 · 1 comment
Assignees
@johnleider
Labels
C: VSnackbar VSnackbar md2 The issue pertains to Material Spec 2
Milestone
v2.0.0

Comments

@185driver
Copy link
Contributor

Versions and Environment

Vuetify: 2.0.0-beta.5
Vue: 2.6.10
Browsers: Chrome 76.0.3809.46
OS: Windows 10

Steps to reproduce

Inspect .v-snack__content element in dev tools and note padding value on the LH side.

Expected Behavior

LH padding should be 16px

Actual Behavior

LH padding is 24px

Reproduction Link

https://codepen.io/anon/pen/YoJZYP

Other comments

Snackbar md2 spec found at https://material.io/design/components/snackbars.html#spec

vuetify-snack-example

md2-snack-example
@ghost ghost added the S: triage label Jul 7, 2019
@jacekkarczmarczyk jacekkarczmarczyk added C: VSnackbar VSnackbar md2 The issue pertains to Material Spec 2 and removed S: triage labels Jul 7, 2019
@johnleider johnleider self-assigned this Jul 7, 2019
@johnleider johnleider added this to the v2.0.0 milestone Jul 7, 2019
johnleider added a commit that referenced this issue Jul 20, 2019
@johnleider
fix(VSnackbar): update to better match md2 spec
9f12df7 
fixes #7772
@johnleider
Copy link
Member

Part of this accidentally went out with 49e3161

Finished remaining parts in: 9f12df7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
C: VSnackbar VSnackbar md2 The issue pertains to Material Spec 2
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
3 participants
@185driver @johnleider @jacekkarczmarczyk