Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] v-icon x-small not working #7873

Closed
gorsat opened this issue Jul 19, 2019 · 2 comments
Closed

[Bug Report] v-icon x-small not working #7873

gorsat opened this issue Jul 19, 2019 · 2 comments
Assignees
Labels
T: bug Functionality that does not work as intended/expected
Milestone

Comments

@gorsat
Copy link

gorsat commented Jul 19, 2019

Versions and Environment

Vuetify: 2.0.0-beta.8
Vue: 2.6.10
Browsers: Chrome 75.0.3770.100
OS: Windows 10

Steps to reproduce

make v-icon with attr x-small

Expected Behavior

an icon is rendered at "extra small" size which is reasonably expected to be "less than the small size"

Actual Behavior

an icon is rendered at medium size (bigger than the small size)

Reproduction Link

https://codepen.io/OGCoder/pen/bXNVoZ

@ghost ghost added the S: triage label Jul 19, 2019
@KaelWD
Copy link
Member

KaelWD commented Jul 20, 2019

v-icon doesn't actually use the x-small prop, it's just inherited from a mixin created for v-btn. @vuetifyjs/core-team should this be added, or just removed from docs?

@KaelWD KaelWD added the pending review The issue is still pending disposition label Jul 20, 2019
@jacekkarczmarczyk
Copy link
Member

Seem natural to use x-small icon in x-small btn, also sizing props should be consistent withing the framework, not sure where these large/small props are used but all components having at least one of these props should have the others

@johnleider johnleider self-assigned this Jul 20, 2019
@johnleider johnleider added T: bug Functionality that does not work as intended/expected and removed pending review The issue is still pending disposition S: triage labels Jul 20, 2019
@johnleider johnleider added this to the v2.0.0 milestone Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

4 participants