fix(VDataTable): make it easier to use custom-filter #7885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change custom-filter signature, added example of custom-filter prop usage and filtering on specific columns.
new signature is
(value: any, search: string | null, item: any): boolean
Motivation and Context
early on in the data-table refactor I combined it and
filter
to make things a bit more straightforward. but I see now that the resultingcustomFilter
function went the wrong way. Replacing it right now is not very straightforward (with a signature of(items: any[], search: string | null, headersWithCustomFilters: TableHeader[], headersWithoutCustomFilters: TableHeader[])
)How Has This Been Tested?
playground, doc example
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).