Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] 10 shows up in pagination options even when overridden #8026

Closed
TheInvoker opened this issue Jul 25, 2019 · 2 comments · Fixed by #8029
Closed

[Bug Report] 10 shows up in pagination options even when overridden #8026

TheInvoker opened this issue Jul 25, 2019 · 2 comments · Fixed by #8029
Assignees
@johnleider
Labels
T: bug Functionality that does not work as intended/expected
Milestone
v2.0.x

Comments

@TheInvoker
Copy link

Environment

Vuetify Version: 2.0.1
Last working version: 2.0.1
Vue Version: 2.6.10
Browsers: Chrome 69.0.3497.100
OS: Windows 10

Steps to reproduce

Open pagination options

Expected Behavior

Only the specified array [50,60,70] should be the options.

Actual Behavior

[10,50,60,70] shows up!!!!!!!!!!!!!!!!!

Reproduction Link

https://codepen.io/anon/pen/NQRRzY?&editable=true&editors=101

Other comments

https://stackoverflow.com/questions/57210397/vuetify-2-10-showing-up-in-pagination-options-even-though-set-a-new-array
@ghost ghost added the S: triage label Jul 25, 2019
@johnleider
Copy link
Member

Workaround for now is explicitly defining the default itemsPerPage:

image

@johnleider johnleider self-assigned this Jul 26, 2019
@johnleider johnleider added T: bug Functionality that does not work as intended/expected and removed S: triage labels Jul 26, 2019
johnleider added a commit that referenced this issue Jul 26, 2019
@johnleider
fix(VDataFooter): select first available option when default does not…
a083fc1 
… match

default itemsPerPage is 10 and was being pushed into the items array

fixes #8026
@johnleider johnleider mentioned this issue Jul 26, 2019
Merged
9 tasks
@johnleider johnleider added this to the v2.0.x milestone Jul 26, 2019
johnleider added a commit that referenced this issue Jul 26, 2019
@johnleider
fix(VDataFooter): better handle custom item options (#8029)
8b7a25b 
* fix(VDataFooter): select first available option when default does not match

default itemsPerPage is 10 and was being pushed into the items array

fixes #8026

* refactor(VDataFooter): clean-up genItemsPerPageSelect method
@TheInvoker
Copy link
Author

This is still an issue.
https://codepen.io/anon/pen/NQRRzY?&editable=true&editors=101
it alerts the options.itemsPerPage which is 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.0.x
Development

Successfully merging a pull request may close this issue.

fix(VDataFooter): better handle custom item options vuetifyjs/vuetify
2 participants
@TheInvoker @johnleider