Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VFileInput): unindent input when icon is empty #8078

Merged
merged 2 commits into from Jul 27, 2019

Conversation

jacekkarczmarczyk
Copy link
Member

Description

also removes tab index from icon, it allowed to tab the icon but enter/space didn't do anything, without it it's still clickable

Motivation and Context

fixes #8049

How Has This Been Tested?

playground, unit

Markup:

<template>
  <v-container>
    <v-file-input prepend-icon="" />
    <v-file-input />
    <v-file-input prepend-icon="mdi-home" />
  </v-container>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #8078 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8078      +/-   ##
==========================================
+ Coverage   85.75%   85.76%   +0.01%     
==========================================
  Files         334      334              
  Lines        9090     9090              
  Branches     2412     2413       +1     
==========================================
+ Hits         7795     7796       +1     
+ Misses       1207     1206       -1     
  Partials       88       88
Impacted Files Coverage Δ
...es/vuetify/src/components/VFileInput/VFileInput.ts 82.81% <100%> (ø) ⬆️
packages/vuetify/src/components/VSelect/VSelect.ts 94.13% <0%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ffc14c...05745d9. Read the comment docs.

nekosaur
nekosaur previously approved these changes Jul 27, 2019
@johnleider johnleider merged commit d1a67ab into master Jul 27, 2019
@johnleider johnleider deleted the fix/#8049-file-input-indented-with-empty-icon branch July 27, 2019 19:42
@lock lock bot locked as resolved and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] v-file-input still "indented" even without prepended icon
3 participants