Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Change Data Footer so it's less confusing if you have 1 row per page #9133

Open
keeganwitt opened this issue Sep 27, 2019 · 0 comments
Open

[Feature Request] Change Data Footer so it's less confusing if you have 1 row per page #9133

keeganwitt opened this issue Sep 27, 2019 · 0 comments
Labels
C: VDataTable VDatatable S: has PR The issue has a pending Pull Request T: enhancement Functionality that enhances existing features

Comments

@keeganwitt
Copy link

Problem to solve

Currently, if I have a row per page of 1, the footer text reads something like "5-5 of 25", for example. This is confusing to users and makes it appear the pagination might have some sort of bug.

Proposed solution

I would use a separate template for the case where there's a row per page of 1, so that it reads like "5 of 25"
@ghost ghost added the S: triage label Sep 27, 2019
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Sep 27, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
85eabb4
@keeganwitt keeganwitt mentioned this issue Sep 27, 2019
Closed
9 tasks
@jacekkarczmarczyk jacekkarczmarczyk added C: VDataTable VDatatable S: has PR The issue has a pending Pull Request T: enhancement Functionality that enhances existing features labels Nov 11, 2019
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 1, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
f21a12c
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 1, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
e7f831d
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 1, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
036cf3b
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 1, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
00008da
@keeganwitt keeganwitt mentioned this issue Dec 1, 2019
Closed
9 tasks
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 1, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
54c6cd3
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 1, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
e6be382
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 1, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
1bc0903
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 1, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
a71a9b0
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 1, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
632bc1a
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 1, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
d08f2e1
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 1, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
3d7099d
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 18, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
fe07e6c
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 18, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
785158e
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 18, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
9c55d86
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 19, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
0e77693
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 19, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
c8a270e
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 19, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
7e10803
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Dec 19, 2019
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
00b62ea
@jacekkarczmarczyk jacekkarczmarczyk removed the S: has PR The issue has a pending Pull Request label Jan 11, 2020
keeganwitt added a commit to keeganwitt/vuetify that referenced this issue Feb 2, 2020
@keeganwitt
Change text of data footer for case of 1 row per page (vuetifyjs#9133)
ed0f2d0
@keeganwitt keeganwitt mentioned this issue Feb 2, 2020
Closed
9 tasks
@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label Feb 29, 2020
@Leespiker Leespiker linked a pull request Apr 5, 2020 that will close this issue
feat(VDataFooter) change text of data footer for case of 1 row per page (#9133) #10428
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: VDataTable VDatatable S: has PR The issue has a pending Pull Request T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(VDataFooter) change text of data footer for case of 1 row per page (#9133) keeganwitt/vuetify
4 participants
@keeganwitt @nekosaur @Leespiker @jacekkarczmarczyk